[lxc-devel] [lxc/lxc] f10fad: Bug #158: Deletion of unnecessary checks before ca...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: f10fad2f53e3f4f2f862bacf218a5aa7feceb505
      https://github.com/lxc/lxc/commit/f10fad2f53e3f4f2f862bacf218a5aa7feceb505
  Author: Markus Elfring <elfring at users.sourceforge.net>
  Date:   2015-01-24 (Sat, 24 Jan 2015)

  Changed paths:
    M src/lxc/attach.c
    M src/lxc/bdev.c
    M src/lxc/cgfs.c
    M src/lxc/cgmanager.c
    M src/lxc/conf.c
    M src/lxc/confile.c
    M src/lxc/lsm/apparmor.c
    M src/lxc/lxc_autostart.c
    M src/lxc/lxc_snapshot.c
    M src/lxc/lxc_start.c
    M src/lxc/lxc_top.c
    M src/lxc/lxc_user_nic.c
    M src/lxc/lxc_usernsexec.c
    M src/lxc/lxccontainer.c
    M src/lxc/lxclock.c
    M src/lxc/network.c
    M src/lxc/parse.c
    M src/lxc/seccomp.c
    M src/python-lxc/lxc.c

  Log Message:
  -----------
  Bug #158: Deletion of unnecessary checks before calls of the function "free"

The function "free" is documented in the way that no action shall occur for
a passed null pointer. It is therefore not needed that a function caller
repeats a corresponding check.
http://stackoverflow.com/questions/18775608/free-a-null-pointer-anyway-or-check-first

This issue was fixed by using the software Coccinelle 1.0.0-rc23.

Signed-off-by: Markus Elfring <elfring at users.sourceforge.net>
Acked-by: Stéphane Graber <stgraber at ubuntu.com>


  Commit: c55d4505e354c203473f1532f785842ea16a16a6
      https://github.com/lxc/lxc/commit/c55d4505e354c203473f1532f785842ea16a16a6
  Author: Markus Elfring <elfring at users.sourceforge.net>
  Date:   2015-01-24 (Sat, 24 Jan 2015)

  Changed paths:
    M src/lxc/cgfs.c
    M src/lxc/lxc_autostart.c
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  Bug #158: Deletion of unnecessary checks before a few calls of LXC functions

The following functions return immediately if a null pointer was passed.
* container_destroy
* lxc_cgroup_process_info_free_and_remove
* lxc_cgroup_put_meta
* toss_list

It is therefore not needed that a function caller repeats a corresponding check.

This issue was fixed by using the software Coccinelle 1.0.0-rc23.

Signed-off-by: Markus Elfring <elfring at users.sourceforge.net>
Acked-by: Stéphane Graber <stgraber at ubuntu.com>


  Commit: 67f69573777d35b291c853733752c2c079bf14e8
      https://github.com/lxc/lxc/commit/67f69573777d35b291c853733752c2c079bf14e8
  Author: Thomas Moschny <thomas.moschny at gmx.de>
  Date:   2015-01-24 (Sat, 24 Jan 2015)

  Changed paths:
    M src/lua-lxc/core.c

  Log Message:
  -----------
  Small fix for Lua 5.3 compatibility.

Signed-off-by: Thomas Moschny <thomas.moschny at gmail.com>
Acked-by: Stéphane Graber <stgraber at ubuntu.com>


  Commit: 1f3fc0d73a88b01bb596b0ea812dc9a5b1f7e5e6
      https://github.com/lxc/lxc/commit/1f3fc0d73a88b01bb596b0ea812dc9a5b1f7e5e6
  Author: Johannes Kastl <mail at ojkastl.de>
  Date:   2015-01-24 (Sat, 24 Jan 2015)

  Changed paths:
    M lxc.spec.in

  Log Message:
  -----------
  rpm: added dependency to lxc-libs to lxc package

Ensures matching versions of lxc and lxc-libs being installed

Signed-off-by: Johannes Kastl <mail at ojkastl.de>
Acked-by: Serge E. Hallyn <serge.hallyn at ubuntu.com>


  Commit: b8ebaa9c78a78e3e3c4043a20d3c84cac9ca7fd1
      https://github.com/lxc/lxc/commit/b8ebaa9c78a78e3e3c4043a20d3c84cac9ca7fd1
  Author: Vicente Olivert Riera <Vincent.Riera at imgtec.com>
  Date:   2015-01-24 (Sat, 24 Jan 2015)

  Changed paths:
    M templates/lxc-gentoo.in

  Log Message:
  -----------
  Gentoo template - Add a hwaddr if there is only one veth

Reuse the code from the Debian template to associate a hwaddr if there
is only one veth interface in the container's config file.

Signed-off-by: Vicente Olivert Riera <Vincent.Riera at imgtec.com>
Acked-by: Stéphane Graber <stgraber at ubuntu.com>


  Commit: 6a9390e349c5df27d1dec072ef2fb30848a35055
      https://github.com/lxc/lxc/commit/6a9390e349c5df27d1dec072ef2fb30848a35055
  Author: Jörg Thalheim <joerg at higgsboson.tk>
  Date:   2015-01-24 (Sat, 24 Jan 2015)

  Changed paths:
    M config/init/systemd/lxc.service.in

  Log Message:
  -----------
  systemd: enable delegate in service file

Signed-off-by: Jörg Thalheim <joerg at higgsboson.tk>
Acked-by: Stéphane Graber <stgraber at ubuntu.com>


Compare: https://github.com/lxc/lxc/compare/ce72f6b466f7...6a9390e349c5