[lxc-devel] [PATCHES] add "--mask-tmp" to lxc-fedora, plus some template script fixes

[Michael Adam]

On 2015-01-13 at 17:15 +0000, Serge Hallyn wrote:
> Quoting Stéphane Graber (stgraber at ubuntu.com):
> > On Tue, Jan 13, 2015 at 02:49:22PM +0000, Serge Hallyn wrote:
> > > Quoting Michael Adam (obnox at samba.org):
> > > > 
> > > > I am happy to do patches for either variant, but will
> > > > wait for more comments on that first.
> > > 
> > > Does anyone else have any opinion?
> > > 
> > > I guess I'd favor having them show up at the bottom of the
> > > template's usage() statement, prefaced by
> > > 
> > > For internal use only (do not pass to lxc-create):
> > 
> > When I wrote the download template, I added them to the usage but in a
> > separate section:
> > 
> > """
> > LXC internal arguments (do not pass manually!):
> > [ --name <name> ]: The container name
> > [ --path <path> ]: The path to the container
> > [ --rootfs <rootfs> ]: The path to the container's rootfs
> > [ --mapped-uid <map> ]: A uid map (user namespaces)
> > [ --mapped-gid <map> ]: A gid map (user namespaces)
> > """
> > 
> > Complete download template usage is:
> > 
> > """
> > LXC container image downloader
> > 
> > Required arguments:
> > [ -d | --dist <distribution> ]: The name of the distribution
> > [ -r | --release <release> ]: Release name/version
> > [ -a | --arch <architecture> ]: Architecture of the container
> > 
> > Optional arguments:
> > [ -h | --help ]: This help message
> > [ -l | --list ]: List all available images
> > [ --variant <variant> ]: Variant of the image (default: "default")
> > [ --server <server> ]: Image server (default: "images.linuxcontainers.org")
> > [ --keyid <keyid> ]: GPG keyid (default: 0x...)
> > [ --keyserver <keyserver> ]: GPG keyserver to use
> > [ --no-validate ]: Disable GPG validation (not recommended)
> > [ --flush-cache ]: Flush the local copy (if present)
> > [ --force-cache ]; Force the use of the local copy even if expired
> > 
> > LXC internal arguments (do not pass manually!):
> > [ --name <name> ]: The container name
> > [ --path <path> ]: The path to the container
> > [ --rootfs <rootfs> ]: The path to the container's rootfs
> > [ --mapped-uid <map> ]: A uid map (user namespaces)
> > [ --mapped-gid <map> ]: A gid map (user namespaces)
> > """
> > 
> > Maybe something like that would work for the other templates too?
> 
> That looks good.

I agree and will follow up with patches.

> We also could put those in a function in a
> /usr/share/lxc/templates/helpers file

Good idea, but I have the impression that not all of
the templates currently support all of these options.
I need to look more. Will probably provide the per-template
patches first, and possibly reconsile later.

Cheers - Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20150113/3c86a5ba/attachment.sig>