[lxc-devel] [lxc/lxc] 1f7645: set close-all-fds by default

GitHub noreply at github.com
Mon Jan 12 22:17:57 UTC 2015


  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 1f76453a74f555e30384591567d87b5b4dac7e21
      https://github.com/lxc/lxc/commit/1f76453a74f555e30384591567d87b5b4dac7e21
  Author: Serge Hallyn <serge.hallyn at ubuntu.com>
  Date:   2015-01-12 (Mon, 12 Jan 2015)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  set close-all-fds by default

When containers request to be daemonized, close-all-fd is
set to true.  But when we switched ot daemonize-by-default we didn't
set close-all-fd by default.

Fix that.  In order to do that we have to always have a lxc_conf
object.  As a consequence, after this patch we can drop a bunch
of checks for c->lxc_conf existing.  We should consider removing
those.  This patch does not do that.

This should close https://github.com/lxc/lxc/issues/354

Signed-off-by: Serge Hallyn <serge.hallyn at ubuntu.com>
Acked-by: Stéphane Graber <stgraber at ubuntu.com>


  Commit: 88322f776c8411048217add42d15d610b28317e2
      https://github.com/lxc/lxc/commit/88322f776c8411048217add42d15d610b28317e2
  Author: Serge Hallyn <serge.hallyn at ubuntu.com>
  Date:   2015-01-12 (Mon, 12 Jan 2015)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  Fix reversed args in mount call

Riya Khanna reported that with a ramfs rootfs the mount to make
/ rprivate was returning -EFAULT.  NULL was being passed as the
mount target.  Pass "/" instead.

Reported-by: riya khanna <riyakhanna1983 at gmail.com>>
Signed-off-by: Serge Hallyn <serge.hallyn at ubuntu.com>
Acked-by: Stéphane Graber <stgraber at ubuntu.com>


Compare: https://github.com/lxc/lxc/compare/fccc348be453...88322f776c84


More information about the lxc-devel mailing list