[lxc-devel] [PATCH] signed off patch explanation

Serge Hallyn serge.hallyn at ubuntu.com
Mon Feb 23 15:12:42 UTC 2015


Quoting Stéphane Graber (stgraber at ubuntu.com):
> On Sat, Feb 21, 2015 at 05:02:28PM +0100, lxc at zitta.fr wrote:
> > signed off patch explanation
> > 
> > Signed-off-by: Guillaume ZITTA <lxc at zitta.fr>
> > ---
> >  content/lxc/contribute.md | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> > 
> > diff --git a/content/lxc/contribute.md b/content/lxc/contribute.md
> > index 5d33cd5..9c830bb 100644
> > --- a/content/lxc/contribute.md
> > +++ b/content/lxc/contribute.md
> > @@ -12,3 +12,16 @@ and not on stable releases, unless the bug only affects a stable release.
> >  # Patch submission process
> >  You may contribute to LXC either by sending a patch or patchset directly
> >  on the [lxc-devel mailing-list](https://lists.linuxcontainers.org/listinfo/lxc-devel).
> > +
> > +## signed patch generation
> > +clone repository :
> > +
> > +    git clone git://github.com/lxc/lxc
> > +    
> > +modify, test, add , commit
> > +
> > +generate patch for all diff from master:
> > +
> > +    git format-patch -s origin/master
> > +
> > +copy/paste generated patch to your mail client
> 
> The copy/paste step is most likely to break your patches if they contain tabs.

I always :r my.patch

> Instead, we should recommend people either send a pull request on github
> (still requires Signed-off-by in commit message) or use the git
> send-email command to send the patchset directly to the mailing-list as
> most of us do.
> 
> > \ No newline at end of file
> > -- 
> > 2.3.0
> > 
> > _______________________________________________
> > lxc-devel mailing list
> > lxc-devel at lists.linuxcontainers.org
> > http://lists.linuxcontainers.org/listinfo/lxc-devel
> 
> -- 
> Stéphane Graber
> Ubuntu developer
> http://www.ubuntu.com



> _______________________________________________
> lxc-devel mailing list
> lxc-devel at lists.linuxcontainers.org
> http://lists.linuxcontainers.org/listinfo/lxc-devel



More information about the lxc-devel mailing list