[lxc-devel] [PATCH] Add information about patch submission

Guillaume ZITTA lxc at zitta.fr
Sat Feb 21 21:35:57 UTC 2015


Add information about patch submission

Signed-off-by: Guillaume ZITTA <lxc at zitta.fr>
---
 content/lxc/contribute.md | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/content/lxc/contribute.md b/content/lxc/contribute.md
index 5d33cd5..0f408b1 100644
--- a/content/lxc/contribute.md
+++ b/content/lxc/contribute.md
@@ -10,5 +10,21 @@ Patches sent upstream for review must be based on the current git tree
 and not on stable releases, unless the bug only affects a stable release.
 
 # Patch submission process
+Every submitted patch **must** be signed off by its author.
+
+The easy way is to use : `git commit -s`
+
+and if you forgot "-s" on a previous commit : `git commit --amend -s`
+
+## The mailing-list way
 You may contribute to LXC either by sending a patch or patchset directly
 on the [lxc-devel mailing-list](https://lists.linuxcontainers.org/listinfo/lxc-devel).
+
+You can use `git format-patch` to generate mailable patch.
+
+Beware of "copy/paste" on mail clients as they can break tabs and lines (see `git send-email` or `git imap-send`).
+
+## The pull-request way
+Fork the repository, create a branch, commit you work (with -s !), and push it.
+
+Then follow the [github's doc](https://help.github.com/articles/creating-a-pull-request/).
\ No newline at end of file
-- 
2.3.0



More information about the lxc-devel mailing list