[lxc-devel] [PATCH 2/3] c/r: get rid of dump_net_info()

Serge Hallyn serge.hallyn at ubuntu.com
Wed Aug 12 15:09:22 UTC 2015


Quoting Tycho Andersen (tycho.andersen at canonical.com):
> On Wed, Aug 12, 2015 at 02:54:14PM +0000, Serge Hallyn wrote:
> > Quoting Tycho Andersen (tycho.andersen at canonical.com):
> > > This was originally used to propagate the bridge and veth names across
> > > hosts, but now we extract both from the container's config file, and
> > 
> > Is that the right thing to do?
> 
> I don't know, actually. I did it so that you could switch bridges
> across hosts (and because the code is considerably simpler); it does
> keep the MAC and all that the same, so in theory it should Just Work.
> Someone who knows more about networks can probably correct me if I'm
> wrong, though :)

I do prefer simple, in general.

My concern with this is that any change to the running container which
was not reflected in the config will not be retained.  I wonder if it
is better to fix dump_net_info() to give the information you actually
want.


More information about the lxc-devel mailing list