[lxc-devel] [lxc/lxc] c9d8f2: lxcapi_restore shouldn't steal the calling process

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: c9d8f2ee720b4fe1b3642be90dfe9418d2232de5
      https://github.com/lxc/lxc/commit/c9d8f2ee720b4fe1b3642be90dfe9418d2232de5
  Author: Tycho Andersen <tycho.andersen at canonical.com>
  Date:   2015-04-06 (Mon, 06 Apr 2015)

  Changed paths:
    M src/lxc/lxc_checkpoint.c
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  lxcapi_restore shouldn't steal the calling process

Previously, lxcapi_restore used the calling process as the lxc monitor process
(and just never returned), requiring users to fork before calling it. This, of
course, would cause problems for things like LXD, which can't fork.

Now, restore() forks the monitor as a child of the process that calls it. Users
who want to daemonize the restore process need to fork themselves.
lxc-checkpoint has been updated to reflect this behavior change.

Signed-off-by: Tycho Andersen <tycho.andersen at canonical.com>
Acked-by: Serge E. Hallyn <serge.hallyn at ubuntu.com>


  Commit: 5b3105f5e4f111c6e855a0aad18793dcc4e985f5
      https://github.com/lxc/lxc/commit/5b3105f5e4f111c6e855a0aad18793dcc4e985f5
  Author: Tycho Andersen <tycho.andersen at canonical.com>
  Date:   2015-04-06 (Mon, 06 Apr 2015)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  don't hang on some errors in do_restore

Instead, the parent always writes a status to the pipe.

Signed-off-by: Tycho Andersen <tycho.andersen at canonical.com>
Acked-by: Serge E. Hallyn <serge.hallyn at ubuntu.com>


  Commit: 3fdf4a73a25b5311af8dd7b8812f68d312ce566a
      https://github.com/lxc/lxc/commit/3fdf4a73a25b5311af8dd7b8812f68d312ce566a
  Author: Tycho Andersen <tycho.andersen at canonical.com>
  Date:   2015-04-06 (Mon, 06 Apr 2015)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  Use SYSERROR instead of perror

It is impolite to print stuff to stderror owned by other people, and they might
miss it anyway since it's not in the normal log location.

Signed-off-by: Tycho Andersen <tycho.andersen at canonical.com>
Acked-by: Serge E. Hallyn <serge.hallyn at ubuntu.com>


Compare: https://github.com/lxc/lxc/compare/428b68dbeb59...3fdf4a73a25b