[lxc-devel] [PATCH] Discontinue the use of in-line comments

[Serge Hallyn]

Quoting Stéphane Graber (stgraber at ubuntu.com):
> Those aren't supported, it's just a lucky coincidence that they weren't
> causing problems.
> 
> Signed-off-by: Stéphane Graber <stgraber at ubuntu.com>

Acked-by: Serge E. Hallyn <serge.hallyn at ubuntu.com>

> ---
>  config/templates/common.conf.in | 27 ++++++++++++++++++---------
>  1 file changed, 18 insertions(+), 9 deletions(-)
> 
> diff --git a/config/templates/common.conf.in b/config/templates/common.conf.in
> index b15b5fa..f01db08 100644
> --- a/config/templates/common.conf.in
> +++ b/config/templates/common.conf.in
> @@ -24,15 +24,24 @@ lxc.cgroup.devices.deny = a
>  lxc.cgroup.devices.allow = c *:* m
>  lxc.cgroup.devices.allow = b *:* m
>  ## Allow specific devices
> -lxc.cgroup.devices.allow = c 1:3 rwm	# /dev/null
> -lxc.cgroup.devices.allow = c 1:5 rwm	# /dev/zero
> -lxc.cgroup.devices.allow = c 1:7 rwm	# /dev/full
> -lxc.cgroup.devices.allow = c 5:0 rwm	# /dev/tty
> -lxc.cgroup.devices.allow = c 5:1 rwm	# /dev/console
> -lxc.cgroup.devices.allow = c 5:2 rwm	# /dev/ptmx
> -lxc.cgroup.devices.allow = c 1:8 rwm	# /dev/random
> -lxc.cgroup.devices.allow = c 1:9 rwm	# /dev/urandom
> -lxc.cgroup.devices.allow = c 136:* rwm	# /dev/pts/*
> +### /dev/null
> +lxc.cgroup.devices.allow = c 1:3 rwm
> +### /dev/zero
> +lxc.cgroup.devices.allow = c 1:5 rwm
> +### /dev/full
> +lxc.cgroup.devices.allow = c 1:7 rwm
> +### /dev/tty
> +lxc.cgroup.devices.allow = c 5:0 rwm
> +### /dev/console
> +lxc.cgroup.devices.allow = c 5:1 rwm
> +### /dev/ptmx
> +lxc.cgroup.devices.allow = c 5:2 rwm
> +### /dev/random
> +lxc.cgroup.devices.allow = c 1:8 rwm
> +### /dev/urandom
> +lxc.cgroup.devices.allow = c 1:9 rwm
> +### /dev/pts/*
> +lxc.cgroup.devices.allow = c 136:* rwm
>  
>  # Blacklist some syscalls which are not safe in privileged
>  # containers
> -- 
> 1.9.1
> 
> _______________________________________________
> lxc-devel mailing list
> lxc-devel at lists.linuxcontainers.org
> http://lists.linuxcontainers.org/listinfo/lxc-devel