[lxc-devel] [lxc/lxc] 145832: do_rootfs_setup: fix return bugs

GitHub noreply at github.com
Mon Oct 27 13:33:46 UTC 2014


  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 145832ba8b1dfd0b53436e6b61ef112bbdd50c6c
      https://github.com/lxc/lxc/commit/145832ba8b1dfd0b53436e6b61ef112bbdd50c6c
  Author: Serge Hallyn <serge.hallyn at ubuntu.com>
  Date:   2014-10-26 (Sun, 26 Oct 2014)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  do_rootfs_setup: fix return bugs

Fix return value on bind mount failure.

If we've already mounted the rootfs, exit after the bind mount
rather than re-trying the rootfs mount.  The only case where
this happens is when root is starting a container in a user
namespace and with a block device backing store.

In that case, pre-mount hooks will be executed in the initial
user namespace.  That may be worth fixing.  Or it may be what
we want.  We should think about it and fix it.

Signed-off-by: Serge Hallyn <serge.hallyn at ubuntu.com>


  Commit: bf1e86368272a7c342ad1eea6d61ac3694e182bf
      https://github.com/lxc/lxc/commit/bf1e86368272a7c342ad1eea6d61ac3694e182bf
  Author: Dark Templar <dark_templar at hotbox.ru>
  Date:   2014-10-27 (Mon, 27 Oct 2014)

  Changed paths:
    M src/lxc/legacy/lxc-ls.in

  Log Message:
  -----------
  Make legacy lxc-ls more robust

Behave well when /etc/lxc/${name} is a symlink to directory

Signed-off-by: Dark Templar <dark_templar at hotbox.ru>
Acked-by: Serge E. Hallyn <serge.hallyn at ubuntu.com>


Compare: https://github.com/lxc/lxc/compare/9fd376e8bc2a...bf1e86368272


More information about the lxc-devel mailing list