[lxc-devel] [PATCH] Gentoo template: fix /etc/conf.d/hostname file

Serge Hallyn serge.hallyn at ubuntu.com
Wed Oct 22 14:34:17 UTC 2014


Quoting Dark Templar (dark_templar at hotbox.ru):
> Hi,
> 
> I've found one more typo in the gentoo template, configuration in the
> generated file /etc/conf.d/hostname was not valid, but it didn't impact
> me due to "lxc.utsname" being set in the configuration file of container
> and hostname service being not used. Anyway, I've made a patch and
> sending it with this mail.

Thanks - in the future (especially if patches become more complicated)
could you please make sure to add your Signed-off-by?

Acked-by: Serge E. Hallyn <serge.hallyn at ubuntu.com>

> Thanks

> From 0f53c7e91d3789aa4e7b69d5fc4da20a05e1e039 Mon Sep 17 00:00:00 2001
> From: Dark Templar <dark_templar at hotbox.ru>
> Date: Sat, 18 Oct 2014 14:26:24 +0400
> Subject: [PATCH] Gentoo template: fix hostname configuration
> 
> ---
>  templates/lxc-gentoo.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/templates/lxc-gentoo.in b/templates/lxc-gentoo.in
> index 659fd28..a4542aa 100644
> --- a/templates/lxc-gentoo.in
> +++ b/templates/lxc-gentoo.in
> @@ -623,7 +623,7 @@ and man lxc.conf"
>  container_hostname()
>  {
>      printf "#### container_hostname(): setting hostname... \n"
> -    printf "hostnale=%s\n" "${name}" > "${rootfs}/etc/conf.d/hostname"
> +    printf "hostname=\"%s\"\n" "${name}" > "${rootfs}/etc/conf.d/hostname"
>      printf " => done.\n"
>  }
>  
> -- 
> 2.0.4
> 

> _______________________________________________
> lxc-devel mailing list
> lxc-devel at lists.linuxcontainers.org
> http://lists.linuxcontainers.org/listinfo/lxc-devel



More information about the lxc-devel mailing list