[lxc-devel] [PATCH 0/9 V2] lxc-device: rewrite lxc-device.

[Serge Hallyn]

Quoting Dongsheng Yang (yangds.fnst at cn.fujitsu.com):
> Hi Serge:
> 	Sorry for the confusion on this thread. Here is the V2
> of this patchset. I have rebased it against lxc/master.
> 
> [1/9] ~ [5/9] and [9/9] are already acked.
> 
> changelogs:
> 	[6/9]: 
> 		* Add a check for switching to userns
> 		* combine switch_to_XXns() to switch_to_ns().
> 	[7/9]: 
> 		* ERROR() out when am_unpriv().
> 
> [8/9] was not reviewed by Serge. It is about python-binding.

Thanks for resending.  The summary was helpful as well.  Sorry I had
 a few more requests.  If you prefer I can implement those changes
 myself on top of your patchset.

> Also, you can get the commits by going to:
> 
> https://github.com/yangdongsheng/lxc/commits/interface_v2
> 
> Any comments, thoughts, proposals are really welcome.
> 
> Thanx
> 
> Dongsheng Yang (9):
>   network: convert param ifname to const.
>   network: check result of if_nametoindex().
>   lxc_start: ERROR if container is already running.
>   network: allow lxc_network_move_by_index() rename netdev in moving.
>   network: introduce a interface named lxc_netdev_isup().
>   utils: move useful helper functions from lxccontainer to utils.
>   container: introduce two functions named as {at/de}tach_interface().
>   python-lxc: Add [at|de]tach_interface() to python binding.
>   lxc-device: rewrite lxc-device.
> 
>  src/lxc/Makefile.am    |   4 +-
>  src/lxc/conf.c         |   4 +-
>  src/lxc/lxc-device     |  97 ---------------------------
>  src/lxc/lxc_device.c   | 173 +++++++++++++++++++++++++++++++++++++++++++++++++
>  src/lxc/lxc_start.c    |   4 ++
>  src/lxc/lxc_unshare.c  |   2 +-
>  src/lxc/lxc_user_nic.c |   2 +-
>  src/lxc/lxccontainer.c | 139 +++++++++++++++++++++++++--------------
>  src/lxc/lxccontainer.h |  19 ++++++
>  src/lxc/network.c      |  90 ++++++++++++++++++++++++-
>  src/lxc/network.h      |   6 +-
>  src/lxc/utils.c        |  26 ++++++++
>  src/lxc/utils.h        |   1 +
>  src/python-lxc/lxc.c   |  73 +++++++++++++++++++++
>  14 files changed, 485 insertions(+), 155 deletions(-)
>  delete mode 100644 src/lxc/lxc-device
>  create mode 100644 src/lxc/lxc_device.c
> 
> -- 
> 1.8.4.2
>