[lxc-devel] [PATCH 1/3] lxccontainer.c: split up cleate_run_template()

TAMUKI Shoichi tamuki at linet.gr.jp
Thu Oct 9 06:52:30 UTC 2014


Hello,

From: Serge Hallyn <serge.hallyn at ubuntu.com>
Subject: Re: [lxc-devel] [PATCH 1/3] lxccontainer.c: split up cleate_run_template()
Date: Wed, 8 Oct 2014 14:12:06 +0000

> > The purpose of this patch was just intended to simplify the code in
> > create_run_template() which only run from within short-lived task that
> > will exit after both the template runs and the password changes.
> > So, I just splitted figureout_rootfs() off in a mechanical manner.
> > 
> > Anyway, I agree with you from a viewpoint of strdup() and free().
> > 
> > Ok, I will revise the other patches to fit without this patch later.
> 
> No no, I think your patch is fine, it just needs the tweak to free
> the bdev.

Oh, I see.  I will soon post the revised patch set.

Regards,
TAMUKI Shoichi


More information about the lxc-devel mailing list