[lxc-devel] [PATCH] lxc-autostart: Damn you double free.

Michael H. Warfield mhw at WittsEnd.com
Sun May 25 16:40:36 UTC 2014


My bad.  Spotted it right off.  Fixed it and retested using the
lxc-test-autostart in the tests.

Looks much better now.

[mhw at hydra tests]$ sudo ./lxc-test-autostart 
Using image from local cache
Unpacking the rootfs

---
You just created an Ubuntu container (release=trusty, arch=amd64, variant=default)
The default username/password is: ubuntu / ubuntu
To gain root privileges, please use sudo.

PASS
[mhw at hydra tests]$

Regards,
Mike


-- 
lxc-autostart: Damn you double free.

Removed a free after calling toss_list (toss_list frees the list
pointer already) that was triggering a double free.

Signed-off-by: Michael H. Warfield <mhw at WittsEnd.com>
---
 src/lxc/lxc_autostart.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/lxc/lxc_autostart.c b/src/lxc/lxc_autostart.c
index 0cab734..920de67 100644
--- a/src/lxc/lxc_autostart.c
+++ b/src/lxc/lxc_autostart.c
@@ -509,7 +509,6 @@ int main(int argc, char *argv[])
 
 	if ( cmd_groups_list ) {
 		toss_list( cmd_groups_list );
-		free(cmd_groups_list);
 	}
 
 	free(containers);
-- 
1.9.0



-- 
Michael H. Warfield (AI4NB) | (770) 978-7061 |  mhw at WittsEnd.com
   /\/\|=mhw=|\/\/          | (678) 463-0932 |  http://www.wittsend.com/mhw/
   NIC whois: MHW9          | An optimist believes we live in the best of all
 PGP Key: 0x674627FF        | possible worlds.  A pessimist is sure of it!

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 482 bytes
Desc: This is a digitally signed message part
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20140525/99ebe4aa/attachment.sig>


More information about the lxc-devel mailing list