[lxc-devel] [PATCH] remove TODO file with old item in it

[Stéphane Graber]

On Mon, May 19, 2014 at 05:24:44PM -0400, Dwight Engen wrote:
> On Mon, 19 May 2014 17:09:02 +0200
> Stéphane Graber <stgraber at ubuntu.com> wrote:
> 
> > On Fri, Apr 18, 2014 at 11:30:15PM +0800, Sheng Yong wrote:
> > > Hi, all
> > > 
> > > These 4 patches create interactive interface for lxc-create.
> > > lxdialog and mconf are used directly from linux kernel. mconf and
> > > corresponding config file are installed at $datadir/lxc/scripts/.
> > > 
> > > '-m | --menuconfig' option forks a new task and executes mconf.
> > > After menuconfig, a default .config file is saved at the current
> > > directory. lxc-create reads and parses .config, then fills the
> > > lxc_arguments.
> > > 
> > > thanks,
> > > shyodx 
> > 
> > Hi,
> > 
> > Sorry for the long delay, it took me a while to make up my mind about
> > this.
> > 
> > So long story short, we won't be including this work in LXC at this
> > point. The main reason for this is that this is a rather big change,
> > which will require ongoing maintenance (whenever a template is added
> > or changes) for what feels like pretty low gain, our users typically
> > are either happy to call lxc-create again with the needed arguments
> > or will create a base container and then just lxc-clone it.
> > 
> > It's always hard to reject a new feature especially when it's clear
> > that you've spent quite a bit of time working on this but I think
> > keeping LXC simple in that regard is the right move for now.
> > 
> > Nacked-by: Stéphane Graber <stgraber at ubuntu.com>
> 
> Stéphane, I agree with your reasoning. Just thought I'd point out that
> Sheng may have done this because it was in the TODO file, which makes
> it a bit more unfortunate :( I had no idea this was in there, but I guess
> its been there since 2009, so maybe we should take it out of there :)
> 
> -->8
> 
> 

Oh, yeah, that'd explain it, I apparently never looked at that TODO or
I'd have dropped it a while ago...

I guess that made sense in Daniel's mind back when he started to work on
LXC and was the author for all templates, doesn't really apply
nowadays...

> Signed-off-by: Dwight Engen <dwight.engen at oracle.com>

Acked-by: Stéphane Graber <stgraber at ubuntu.com>

> ---
>  TODO | 6 ------
>  1 file changed, 6 deletions(-)
>  delete mode 100644 TODO
> 
> diff --git a/TODO b/TODO
> deleted file mode 100644
> index 56d5056..0000000
> --- a/TODO
> +++ /dev/null
> @@ -1,6 +0,0 @@
> -
> -
> -* create an interactive configuration with the lxc-create command
> -  line, like the 'make menuconfig' of the kernel.
> -
> -  = lxc-create [-n foo] -m|--menuconfig
> -- 
> 1.9.0
> 
> _______________________________________________
> lxc-devel mailing list
> lxc-devel at lists.linuxcontainers.org
> http://lists.linuxcontainers.org/listinfo/lxc-devel

-- 
Stéphane Graber
Ubuntu developer
http://www.ubuntu.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20140519/c1f933e2/attachment.sig>