[lxc-devel] [PATCH] lxc-oracle: export upstart environment variable for maygetty

Dwight Engen dwight.engen at oracle.com
Fri May 16 13:52:18 UTC 2014


On Fri, 16 May 2014 13:45:52 +0000
Serge Hallyn <serge.hallyn at ubuntu.com> wrote:

> Quoting Dwight Engen (dwight.engen at oracle.com):
> > This is a fix to commit 5f2ea8cfcb8ccd9bbb7cf18e1e260044f3f6dcaf.
> > Sorry, not sure how I missed this in testing the original patch.
> > 
> > Signed-off-by: Dwight Engen <dwight.engen at oracle.com>
> 
> In the general case I assume this will work, but if I happen
> to do a 'stop console; start console' then $container will be
> empty right?  Any reason not to just do
> 
> env container=lxc
> 
> ?

Hmm, yeah I hadn't considered that case. But I don't think we can just
do container=lxc because won't that override the container=libvirt-lxc
case this is meant to handle in the first place?
 
> > ---
> >  templates/lxc-oracle.in | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/templates/lxc-oracle.in b/templates/lxc-oracle.in
> > index 1cf1b1b..2fa289b 100644
> > --- a/templates/lxc-oracle.in
> > +++ b/templates/lxc-oracle.in
> > @@ -403,6 +403,7 @@ EOF
> >  
> >  start on stopped rc RUNLEVEL=[2345]
> >  stop on runlevel [!2345]
> > +env container
> >  
> >  respawn
> >  exec /sbin/maygetty --nohangup --noclear /dev/console
> > -- 
> > 1.9.0
> > 
> > _______________________________________________
> > lxc-devel mailing list
> > lxc-devel at lists.linuxcontainers.org
> > http://lists.linuxcontainers.org/listinfo/lxc-devel
> _______________________________________________
> lxc-devel mailing list
> lxc-devel at lists.linuxcontainers.org
> http://lists.linuxcontainers.org/listinfo/lxc-devel



More information about the lxc-devel mailing list