[lxc-devel] [PATCH] Make systemd lxc.service use lxc-autostart

Michael H. Warfield mhw at WittsEnd.com
Thu May 1 16:11:45 UTC 2014


On Thu, 2014-05-01 at 11:59 -0400, Stéphane Graber wrote:
> On Thu, May 01, 2014 at 11:46:54AM -0400, Michael H. Warfield wrote:
> > [PATCH] Make systemd lxc.service use lxc-autostart
> > 
> > Changes lxc.service to call lxc-autostart for starting and
> > stopping containers.
> > 
> > Signed-off-by: Michael H. Warfield <mhw at WittsEnd.com>

> Nak.

> You probably meant lxc-autostart rather than lxc-start. You also
> probably don't want an absolute path in there (or if you do, you should
> be using autoconf to template it for you).

> Might also be worth testing the unit before sending it upstream ;)

Crap.  You're right.  But, I thought I did test it.  I rebooted the
entire server and things came up correctly.

Ok...  Well, Dwight has chimed in with another suggestion as well.

Oh, well.  Back to the drawing boards.

Mike

> > ---
> >  config/init/systemd/lxc.service | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/config/init/systemd/lxc.service b/config/init/systemd/lxc.service
> > index aa20b91..4573702 100644
> > --- a/config/init/systemd/lxc.service
> > +++ b/config/init/systemd/lxc.service
> > @@ -6,8 +6,8 @@ After=syslog.target
> >  Type=oneshot
> >  RemainAfterExit=yes
> >  ExecStartPre=/usr/libexec/lxc/lxc-devsetup
> > -ExecStart=/usr/libexec/lxc/lxc-startup start
> > -ExecStop=/usr/libexec/lxc/lxc-startup stop
> > +ExecStart=/usr/bin/lxc-start -a
> > +ExecStop=/usr/bin/lxc-start -s
> >  # Environment=BOOTUP=serial
> >  # Environment=CONSOLETYPE=serial
> >  StandardOutput=syslog
> > -- 
> > 1.9.0
> > 
> > 
> > -- 
> > Michael H. Warfield (AI4NB) | (770) 978-7061 |  mhw at WittsEnd.com
> >    /\/\|=mhw=|\/\/          | (678) 463-0932 |  http://www.wittsend.com/mhw/
> >    NIC whois: MHW9          | An optimist believes we live in the best of all
> >  PGP Key: 0x674627FF        | possible worlds.  A pessimist is sure of it!
> > 
> 
> 
> 
> > _______________________________________________
> > lxc-devel mailing list
> > lxc-devel at lists.linuxcontainers.org
> > http://lists.linuxcontainers.org/listinfo/lxc-devel
> 
> 
> _______________________________________________
> lxc-devel mailing list
> lxc-devel at lists.linuxcontainers.org
> http://lists.linuxcontainers.org/listinfo/lxc-devel

-- 
Michael H. Warfield (AI4NB) | (770) 978-7061 |  mhw at WittsEnd.com
   /\/\|=mhw=|\/\/          | (678) 463-0932 |  http://www.wittsend.com/mhw/
   NIC whois: MHW9          | An optimist believes we live in the best of all
 PGP Key: 0x674627FF        | possible worlds.  A pessimist is sure of it!

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 482 bytes
Desc: This is a digitally signed message part
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20140501/f7530c83/attachment.sig>


More information about the lxc-devel mailing list