[lxc-devel] [PATCH 1/3] Fix default package selection

[Serge Hallyn]

Quoting Leonid Isaev (lisaev at umail.iu.edu):
> Do not cherry-pick packages for the default install to avoid dependency issues. Instead, install the base group modulo blacklisted packages.
> 
> Signed-off-by: Leonid Isaev <lisaev at umail.iu.edu>

Hi - these look good to me (except for adding bashisms which is
something we generally try to avoid), but I'm not a user/admin/
developer on arch linux.  Alexander or John, do these 3 look
good to you?

> ---
>  templates/lxc-archlinux.in | 32 ++++++--------------------------
>  1 file changed, 6 insertions(+), 26 deletions(-)
> 
> diff --git a/templates/lxc-archlinux.in b/templates/lxc-archlinux.in
> index 15283df..5aa9e53 100644
> --- a/templates/lxc-archlinux.in
> +++ b/templates/lxc-archlinux.in
> @@ -47,32 +47,12 @@ default_locale="en-US.UTF-8"
>  default_timezone="UTC"
>  pacman_config="/etc/pacman.conf"
>  
> -# sort of minimal package set
> -base_packages=(
> -    "systemd"
> -    "systemd-sysvcompat"
> -    "filesystem"
> -    "coreutils"
> -    "kmod"
> -    "procps"
> -    "psmisc"
> -    "pacman"
> -    "bash"
> -    "cronie"
> -    "iproute2"
> -    "iputils"
> -    "inetutils"
> -    "dhcpcd"
> -    "dnsutils"
> -    "nano"
> -    "grep"
> -    "less"
> -    "gawk"
> -    "sed"
> -    "tar"
> -    "gzip"
> -    "which"
> -)
> +# by default, install 'base' except the kernel
> +pkg_blacklist="linux"
> +base_packages=()
> +for pkg in $(pacman -Sqg base); do
> +   [[ "${pkg_blacklist//$pkg/}" = "$pkg_blacklist" ]] && base_packages+=($pkg)
> +done
>  declare -a additional_packages
>  
>  # split comma-separated string into an array
> -- 
> 1.8.5.3
> 
> -- 
> Leonid Isaev
> GnuPG key fingerprint: C0DF 20D0 C075 C3F1 E1BE  775A A7AE F6CB 164B 5A6D



> _______________________________________________
> lxc-devel mailing list
> lxc-devel at lists.linuxcontainers.org
> http://lists.linuxcontainers.org/listinfo/lxc-devel