[lxc-devel] [lxc/lxc] ef5362: lxc-debian: Don't eat the argument after -c

GitHub noreply at github.com
Fri Mar 21 14:53:09 UTC 2014


  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: ef53625fe1b7d29fc0676564ddc28c96008384ac
      https://github.com/lxc/lxc/commit/ef53625fe1b7d29fc0676564ddc28c96008384ac
  Author: Stéphane Graber <stgraber at ubuntu.com>
  Date:   2014-03-21 (Fri, 21 Mar 2014)

  Changed paths:
    M templates/lxc-debian.in

  Log Message:
  -----------
  lxc-debian: Don't eat the argument after -c

Reported-by: Robie Basak <robie.basak at canonical.com>
Signed-off-by: Stéphane Graber <stgraber at ubuntu.com>
Acked-by: Serge E. Hallyn <serge.hallyn at ubuntu.com>


  Commit: a526a632e007c0d666dbe953cf7b39fbf26b63db
      https://github.com/lxc/lxc/commit/a526a632e007c0d666dbe953cf7b39fbf26b63db
  Author: Serge Hallyn <serge.hallyn at ubuntu.com>
  Date:   2014-03-21 (Fri, 21 Mar 2014)

  Changed paths:
    M doc/lxc-create.sgml.in

  Log Message:
  -----------
  lxc-create manpage: specify -B best option

Signed-off-by: Serge Hallyn <serge.hallyn at ubuntu.com>
Acked-by: Stéphane Graber <stgraber at ubuntu.com>


  Commit: 23e880832b90190563b01fdd73fdcd5948492e52
      https://github.com/lxc/lxc/commit/23e880832b90190563b01fdd73fdcd5948492e52
  Author: Holger Amann <holger at sauspiel.de>
  Date:   2014-03-21 (Fri, 21 Mar 2014)

  Changed paths:
    M templates/lxc-debian.in

  Log Message:
  -----------
  debian: Symlink /etc/mtab

/etc/mtab doesn’t exist after bootstrapping a debian container, and will
be created as regular file after first start.

That leads to at least two errors:
- output of `mount` is wrong and get messed up the more often you
  start/stop the container
- /dev/pts/ptmx has wrong permissions

Signed-off-by: Holger Amann <holger at sauspiel.de>
Acked-by: Stéphane Graber <stgraber at ubuntu.com>


  Commit: 79bff4f8862e119b2bb672b0649c73b7f3681291
      https://github.com/lxc/lxc/commit/79bff4f8862e119b2bb672b0649c73b7f3681291
  Author: Serge Hallyn <serge.hallyn at ubuntu.com>
  Date:   2014-03-21 (Fri, 21 Mar 2014)

  Changed paths:
    M src/lxc/cgmanager.c

  Log Message:
  -----------
  mutex cgmanager access

It looks like either libdbus or libnih is showing some corruption with
threaded access to the cgmanager-client library.  Until we can
straighten that out, mutex access to the cgmanager.

The worst part of this is having to take and drop the mutex at every
fork.  This also means that we can't keep a connection open for the
duration of container startup, since that would deadlock forks.

If we were going to keep it like this, then we could get rid of some
code in start.c.  However we take a performance hit here which I
really hope we can rectify soon.

The other approach we could take would be to keep a global count of
references to cgroup_manager.  Mutex the open, close, and each use
of the cgroup_manager proxy (and the inc/dec of the refcount).  This
way we could in fact keep the connection open for the duration of
container start.  The atfork handler child_fn would have to close
the connection if open.

Signed-off-by: Serge Hallyn <serge.hallyn at ubuntu.com>
Acked-by: Stéphane Graber <stgraber at ubuntu.com>


Compare: https://github.com/lxc/lxc/compare/0cd97e965832...79bff4f8862e


More information about the lxc-devel mailing list