[lxc-devel] [PATCH] Add tuning knob to not expire root password in centos template

[Serge Hallyn]

Quoting Michael H. Warfield (mhw at WittsEnd.com):
> On Mon, 2014-03-17 at 09:06 -0500, Serge Hallyn wrote:
> > Quoting Mingjiang Shi (mrjewes at gmail.com):
> > > Hi All,
> > > This patch adds a tuning knob (environment variable) to not expire the root
> > > password.
> > > 
> > > Use case: One wants to set the root password when creating the container,
> > > so he/she doesn't want to the password to be expired.
> > > 
> > > Usage:
> > > root_password="<root password for the container>" root_expire_password=no
> > > lxc-create -t centos -n <container name>
> > > 
> > > Signed-off-by: Mingjiang Shi <mrjewes at gmail dot com>
> 
> > I don't particularly like the use of == in shell (except when
> > intended), but it'll do the right thing in this case.
> 
> Yeah, I saw that little niggle and thought it might be one more thing to

BTW it wasn't meant as a criticism - I do it myself all the time,
which is precisely why it's so dangerous :)

> clean up down the road (script has a couple of problems when switching
> from #!/bin/bash to #!/bin/sh) but wasn't going to call that a show
> stopper.
> 
> > Acked-by: Serge E. Hallyn <serge.hallyn at ubuntu.com>
> 
> > I'll wait until Michael's review to apply.
> 
> I'm good with it.
> 
> Acked-by: Michael H. Warfield <mhw at WittsEnd.com>

thanks

-serge