[lxc-devel] [lxc/lxc] c18d41: removed shebang from bash_completion-file

GitHub noreply at github.com
Mon Mar 3 16:05:11 UTC 2014


  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: c18d419f7c725f9073454f996a3fb51365cf925a
      https://github.com/lxc/lxc/commit/c18d419f7c725f9073454f996a3fb51365cf925a
  Author: Johannes Kastl <git at ojkastl.de>
  Date:   2014-03-03 (Mon, 03 Mar 2014)

  Changed paths:
    M config/bash/lxc.in

  Log Message:
  -----------
  removed shebang from bash_completion-file

Signed-off-by: Johannes Kastl <git at ojkastl.de>
Acked-by: Stéphane Graber <stgraber at ubuntu.com>


  Commit: 73d28d4295aea27abc38a309ba94b2046675abc1
      https://github.com/lxc/lxc/commit/73d28d4295aea27abc38a309ba94b2046675abc1
  Author: Serge Hallyn <serge.hallyn at ubuntu.com>
  Date:   2014-03-03 (Mon, 03 Mar 2014)

  Changed paths:
    M src/lxc/cgmanager.c
    M src/lxc/cgroup.c
    M src/lxc/cgroup.h
    M src/lxc/start.c

  Log Message:
  -----------
  cgmanager: don't stay connected

There are only a few times when we need to be connected to the
cgroup manager:

* when starting a container, from cgm_init until we've set cgroup limits
* when changing a cgroup setting (while running)
* when cleaning up (when shutting down)
* around the cgroup entering at attach

So only connect/disconnect the cgmanager socket on-demand as
needed.  This should have a few benefits.

1. Reduce the # open fds when many containers are running
2. if cgmanager is stopped and restarted, the container
   doesn't have to deal with the disconnection.

This is currently RFC.  There are a few issues outstanding:

1. the cgm_set and cgm_get may need to be made thread-safe.
2. a non-daemonized start which fails while cgm is connected,
will not disconnected.

Signed-off-by: Serge Hallyn <serge.hallyn at ubuntu.com>
Acked-by: Stéphane Graber <stgraber at ubuntu.com>


  Commit: 65db0e5a25839f24fd0f314b113b20dc48caf97b
      https://github.com/lxc/lxc/commit/65db0e5a25839f24fd0f314b113b20dc48caf97b
  Author: S.Çağlar Onur <caglar at 10ur.org>
  Date:   2014-03-03 (Mon, 03 Mar 2014)

  Changed paths:
    M src/lxc/bdev.c

  Log Message:
  -----------
  use btrfs snapshot feature to restore snapshots

fixes #131

changes since v1;
* uses btrfs snapshot feature only if src and dest are on same fs

Signed-off-by: S.Çağlar Onur <caglar at 10ur.org>
Acked-by: Serge E. Hallyn <serge.hallyn at ubuntu.com>


  Commit: 8d2efe40a32700eaec6a8f3057b3b9bb16721b3d
      https://github.com/lxc/lxc/commit/8d2efe40a32700eaec6a8f3057b3b9bb16721b3d
  Author: Serge Hallyn <serge.hallyn at ubuntu.com>
  Date:   2014-03-03 (Mon, 03 Mar 2014)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  clone: don't ever mark the clone's rootfs as being the old, on disk

Otherwise an interrupted clone can lead to the original rootfs
being delete.

There is a period during lxcapi_clone during which we have written down
a temporary configuration file on disk, for the new container, using the
old rootfs. Interruption of clone doesn't allow us to do the cleanup we
do in error paths, so a subsequent lxc-destroy removes the old rootfs.

Fix this by doing the copy_storage as early as possible, and not
writing down the rootfs when we write down the temporary configuration
file.

(note - I tested this by putting a series of
'if (strcmp(newname, "u%d") == 0) exit(1)' inline to trigger
interruption between most blocks.  If someone has a good idea
for a generic way to regression-test this henceforth that'd be
great)

See https://bugs.launchpad.net/lxc/+bug/1285850

Signed-off-by: Serge Hallyn <serge.hallyn at ubuntu.com>
Acked-by: Stéphane Graber <stgraber at ubuntu.com>


  Commit: b7f954bbddc50844e5ea3f7e72170173f5cecfb7
      https://github.com/lxc/lxc/commit/b7f954bbddc50844e5ea3f7e72170173f5cecfb7
  Author: Serge Hallyn <serge.hallyn at ubuntu.com>
  Date:   2014-03-03 (Mon, 03 Mar 2014)

  Changed paths:
    M src/lxc/conf.c
    M src/lxc/utils.c
    M src/lxc/utils.h

  Log Message:
  -----------
  simpler shared rootfs handling

Only do the funky chroot_into_slave if / is in fact the rootfs.
Rootfs is a special blacklisted case for pivot_root.

If / is not rootfs but is shared, just mount / rslave.  We're
already in our own namespace.

This appears to solve the extra /proc/$$/mount entries in
containers and the host directories in lxc-attach which have
been plagueing at least fedora and arch.

Signed-off-by: Serge Hallyn <serge.hallyn at ubuntu.com>
Acked-by: Stéphane Graber <stgraber at ubuntu.com>


Compare: https://github.com/lxc/lxc/compare/9f15e86afa60...b7f954bbddc5


More information about the lxc-devel mailing list