[lxc-devel] Remove shebang from config/bash/lxc.in?

[Stéphane Graber]

On Sat, Mar 01, 2014 at 09:55:08PM +0100, Johannes Kastl wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Hi everyone,
> 
> I tried to build the latest version of lxc on the openSUSE
> buildservice, so it would get into openSUSE factory and tumbleweed.
> 
> One of the errors during build was the shebang that is in the
> bash_completion-file (config/bash/lxc.in in the source).
> 
> I was asked by the maintainer to submit the patch upstream, so here it
> is. (I hope this is the right way to submit a patch.)
> 
> I'm not familiar with what has to be in a bash_completion-file, so if
> this is an error that has to be neglected, please just say so.
> 
> Hints and comments welcome...
> 
> Regards,
> Johannes

Hi,

Looks good but upstream requires sign off on your commits, can you
resubmit with a Signed-off-by line in your commit message?

Thanks

> - -- 
> `Don't, Ginny, we'll send you loads of owls.´ `We'll send you a
> Hogwarts toilet seat.´ `George!´ `Only joking, Mum.´
> (Harry Potter and the Philosopher's Stone)
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1
> Comment: Using GnuPG with SeaMonkey - http://www.enigmail.net/
> 
> iEYEARECAAYFAlMSSSwACgkQzi3gQ/xETbIOtgCfQhtIW/74Od5sbYaj3X0JC7Ux
> V1cAoJdWL9M8nlL+8hSK6QCf2Du7LGVm
> =iH2Q
> -----END PGP SIGNATURE-----

> From 9f20eedf502fb4b01b49e5ae550d280c8b4017dc Mon Sep 17 00:00:00 2001
> From: Johannes Kastl <git at ojkastl.de>
> Date: Sat, 1 Mar 2014 21:48:11 +0100
> Subject: [PATCH] removed shebang from bash_completion-file
> 
> ---
>  config/bash/lxc.in | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/config/bash/lxc.in b/config/bash/lxc.in
> index c1c9041..18fd48f 100644
> --- a/config/bash/lxc.in
> +++ b/config/bash/lxc.in
> @@ -1,5 +1,3 @@
> -#!bash
> -
>  have lxc-start && {
>      _lxc_names() {
>          COMPREPLY=( $( compgen -W "$( lxc-ls )" "$cur" ) )
> -- 
> 1.8.5.5
> 

> _______________________________________________
> lxc-devel mailing list
> lxc-devel at lists.linuxcontainers.org
> http://lists.linuxcontainers.org/listinfo/lxc-devel


-- 
Stéphane Graber
Ubuntu developer
http://www.ubuntu.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20140301/8ff13e8d/attachment.pgp>