[lxc-devel] [PATCH] don't build init.lxc.static if libcap.a isn't available

[Serge Hallyn]

Quoting Dwight Engen (dwight.engen at oracle.com):
> On Fri, 20 Jun 2014 20:48:57 +0000
> Serge Hallyn <serge.hallyn at ubuntu.com> wrote:
> 
> > Quoting Dwight Engen (dwight.engen at oracle.com):
> > > Note that building init.lxc.static still requires a static libutil.a
> > > and libpthread.a, but these are available on most distro's through
> > > glibc-static.
> > > 
> > > Signed-off-by: Dwight Engen <dwight.engen at oracle.com>
> > 
> > Acked-by: Serge E. Hallyn <serge.hallyn at ubuntu.com>
> > 
> > Ok if needed, but didn't you just pull the lxc_caps* out of
> > lxc_init.c?  Are we inheriting the depends through some other
> > includes?
> 
> We still have log.c->lxc_unpriv()->lxc_caps_[up|down]()
> I posted some alternative solutions to that in the original thread:
> 
> http://permalink.gmane.org/gmane.linux.kernel.containers.lxc.devel/8573

I think I'm happy with your option 3.  I vote for leaving it as is.

thanks,
-serge