[lxc-devel] [PATCH 1/1] Remove mention of mountcgroups in ubuntu.common config

[Stéphane Graber]

On Thu, Jul 17, 2014 at 02:08:59PM +0000, Serge Hallyn wrote:
> That mount hook predates the lxc.mount.auto = cgroup option.  So mention
> that instead.
> 
> Perhaps we should simply drop the mountcgroup hook from the tree, but
> I'm not doing that in this patch.
> 
> (This addresses https://bugs.launchpad.net/ubuntu/+source/lxc/+bug/1342960)
> 
> Signed-off-by: Serge Hallyn <serge.hallyn at ubuntu.com>

Acked-by: Stéphane Graber <stgraber at ubuntu.com>

And unless someone strongly feels otherwise, I'd +1 the removal of the
hook from the tree too.

> ---
>  config/templates/ubuntu.common.conf.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/config/templates/ubuntu.common.conf.in b/config/templates/ubuntu.common.conf.in
> index 631b4bb..19a6a67 100644
> --- a/config/templates/ubuntu.common.conf.in
> +++ b/config/templates/ubuntu.common.conf.in
> @@ -17,7 +17,7 @@ lxc.mount.entry = /sys/fs/pstore sys/fs/pstore none bind,optional 0 0
>  # To support container nesting on an Ubuntu host while retaining most of
>  # apparmor's added security, use the following two lines instead.
>  #lxc.aa_profile = lxc-container-default-with-nesting
> -#lxc.hook.mount = /usr/share/lxc/hooks/mountcgroups
> +#lxc.mount.auto = cgroup:mixed
>  
>  # Uncomment the following line to autodetect squid-deb-proxy configuration on the
>  # host and forward it to the guest at start time.
> -- 
> 1.9.1
> 
> _______________________________________________
> lxc-devel mailing list
> lxc-devel at lists.linuxcontainers.org
> http://lists.linuxcontainers.org/listinfo/lxc-devel

-- 
Stéphane Graber
Ubuntu developer
http://www.ubuntu.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20140718/4c2751be/attachment.sig>