[lxc-devel] [PATCH 8/8] Include config.h early for _GNU_SOURCE with uClibc

Serge Hallyn serge.hallyn at ubuntu.com
Wed Jan 29 15:07:58 UTC 2014


Quoting Natanael Copa (ncopa at alpinelinux.org):
> This fixes the following compile errors with uClibc:
> 
> lxc_snapshot.c: In function 'print_file':
> lxc_snapshot.c:71:2: error: implicit declaration of function 'getline' [-Werror=implicit-function-declaration]
>   while (getline(&line, &sz, f) != -1) {
>   ^
> cc1: all warnings being treated as errors
> 
> lxc_usernsexec.c: In function 'read_default_map':
> lxc_usernsexec.c:181:2: error: implicit declaration of function 'getline' [-Werror=implicit-function-declaration]
>   while (getline(&line, &sz, fin) != -1) {
>   ^
> cc1: all warnings being treated as errors
> 
> Signed-off-by: Natanael Copa <ncopa at alpinelinux.org>

Acked-by: Serge E. Hallyn <serge.hallyn at ubuntu.com>

> ---
>  src/lxc/lxc_snapshot.c   | 1 +
>  src/lxc/lxc_usernsexec.c | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/lxc/lxc_snapshot.c b/src/lxc/lxc_snapshot.c
> index 9a8f6a4..a49e8d7 100644
> --- a/src/lxc/lxc_snapshot.c
> +++ b/src/lxc/lxc_snapshot.c
> @@ -16,6 +16,7 @@
>   * with this program; if not, write to the Free Software Foundation, Inc.,
>   * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
>   */
> +#include "config.h"
>  
>  #include <stdio.h>
>  #include <libgen.h>
> diff --git a/src/lxc/lxc_usernsexec.c b/src/lxc/lxc_usernsexec.c
> index 8335725..b82bcf8 100644
> --- a/src/lxc/lxc_usernsexec.c
> +++ b/src/lxc/lxc_usernsexec.c
> @@ -21,6 +21,7 @@
>   * License along with this library; if not, write to the Free Software
>   * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
>   */
> +#include "config.h"
>  
>  #include <stdio.h>
>  #include <stdlib.h>
> @@ -39,7 +40,6 @@
>  #include <pwd.h>
>  #include <grp.h>
>  
> -#include "config.h"
>  #include "namespace.h"
>  #include "utils.h"
>  
> -- 
> 1.8.5.3
> 
> _______________________________________________
> lxc-devel mailing list
> lxc-devel at lists.linuxcontainers.org
> http://lists.linuxcontainers.org/listinfo/lxc-devel


More information about the lxc-devel mailing list