[lxc-devel] [PATCH] Update CentOS and Fedora templates to support archtectures option.
Michael H. Warfield
mhw at WittsEnd.com
Fri Jan 24 17:22:50 UTC 2014
On Fri, 2014-01-24 at 11:46 -0500, Stéphane Graber wrote:
> On Thu, Jan 23, 2014 at 03:58:16PM -0500, Michael H. Warfield wrote:
> > Update CentOS and Fedora templates to support archtecture option.
> >
> > Added code to the CentOS and Fedora templates so that x86 32 bit containers
> > may be built on x86_64 platforms. Like archectectures may also be trivially
> > used as well.
> >
> > Option added is "-a {arch}".
> >
> > Additionally cleaned up some bash specific logic.
> >
> > Signed-off-by: Michael H. Warfield <mhw at WittsEnd.com>
>
> One comment below.
>
> > ---
[[ Snip ]]
> > -options=$(getopt -o hp:n:cR: -l help,path:,rootfs:,name:,clean,release:,fqdn: -- "$@")
> > +options=$(getopt -o a:hp:n:cR: -l help,path:,rootfs:,name:,clean,release:,fqdn: -- "$@")
> You forgot to add the long name ^
CRAP! You're absolutely right. Do you want to just hand edit that or
do you want me to submit another patch? I got it right in the Fedora
case. I have no excuse for missing it here. :-P
[[ Snip ]]
> >
> > -options=$(getopt -o hp:n:cR: -l help,path:,rootfs:,name:,clean,release:,fqdn: -- "$@")
> > +options=$(getopt -o a:hp:n:cR: -l help,path:,rootfs:,name:,clean,release:,arch:,fqdn: -- "$@")
I swear I thought I had just copied that line over, but, obviously, I
hadn't. Sigh...
Regards,
Mike
--
Michael H. Warfield (AI4NB) | (770) 978-7061 | mhw at WittsEnd.com
/\/\|=mhw=|\/\/ | (678) 463-0932 | http://www.wittsend.com/mhw/
NIC whois: MHW9 | An optimist believes we live in the best of all
PGP Key: 0x674627FF | possible worlds. A pessimist is sure of it!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 465 bytes
Desc: This is a digitally signed message part
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20140124/08f94b73/attachment.pgp>
More information about the lxc-devel
mailing list