[lxc-devel] [PATCH 1/1] lxc_init: don't fail on bad signals

Stéphane Graber stgraber at ubuntu.com
Thu Jan 23 02:54:30 UTC 2014


On Wed, Jan 22, 2014 at 08:49:55PM -0600, Serge Hallyn wrote:
> Changelog: Jan 22: as Michael Warfield pointed out, we should only
> ignore EINVAL, since EFAULT points to a more serious problem.
> 
> Signed-off-by: Serge Hallyn <serge.hallyn at ubuntu.com>

Acked-by: Stéphane Graber <stgraber at ubuntu.com>

> ---
>  src/lxc/lxc_init.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/lxc/lxc_init.c b/src/lxc/lxc_init.c
> index ae64af8..3e51c00 100644
> --- a/src/lxc/lxc_init.c
> +++ b/src/lxc/lxc_init.c
> @@ -159,7 +159,7 @@ int main(int argc, char *argv[])
>  
>  		act.sa_flags = 0;
>  		act.sa_handler = interrupt_handler;
> -		if (sigaction(i, &act, NULL)) {
> +		if (sigaction(i, &act, NULL) && errno != EINVAL) {
>  			SYSERROR("failed to sigaction");
>  			exit(EXIT_FAILURE);
>  		}
> -- 
> 1.8.5.3
> 
> _______________________________________________
> lxc-devel mailing list
> lxc-devel at lists.linuxcontainers.org
> http://lists.linuxcontainers.org/listinfo/lxc-devel

-- 
Stéphane Graber
Ubuntu developer
http://www.ubuntu.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20140122/88253280/attachment.pgp>


More information about the lxc-devel mailing list