[lxc-devel] [lxc/lxc] 72cf75: lxc-start: store PID file to lxc_container

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 72cf75fa33b97104c5e9905aab1be8d335119e7b
      https://github.com/lxc/lxc/commit/72cf75fa33b97104c5e9905aab1be8d335119e7b
  Author: Qiang Huang <h.huangqiang at huawei.com>
  Date:   2014-01-22 (Wed, 22 Jan 2014)

  Changed paths:
    M src/lxc/lxc_start.c
    M src/lxc/lxccontainer.c
    M src/lxc/lxccontainer.h

  Log Message:
  -----------
  lxc-start: store PID file to lxc_container

So we can remove PID file untill lxc_container_free.

This also fix bug: https://github.com/lxc/lxc/issues/89

Signed-off-by: Qiang Huang <h.huangqiang at huawei.com>
Acked-by: Serge E. Hallyn <serge.hallyn at ubuntu.com>


  Commit: 6eaac3034e8c19eab2b91e201628c4ab5a85a085
      https://github.com/lxc/lxc/commit/6eaac3034e8c19eab2b91e201628c4ab5a85a085
  Author: Qiang Huang <h.huangqiang at huawei.com>
  Date:   2014-01-22 (Wed, 22 Jan 2014)

  Changed paths:
    M src/lxc/lxc_start.c
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  daemon: fix the wrong pid in daemon model

When you start a container in daemon model, you have at least
3 processes:
 1. The command the user start (lxc-start -d)
 2. The backgrounded fork of that command after start() is done
 3. The container init process

In PID file, we need (2), but currently we are writing (1),
this is wrong because (1) exits as soon as the container is
started, it's complately useless.

So we write pid after daemonize, so that we'll always write
the right pid to PID file.

Reported-by: Stephane Graber <stgraber at ubuntu.com>
Signed-off-by: Qiang Huang <h.huangqiang at huawei.com>
Acked-by: Serge E. Hallyn <serge.hallyn at ubuntu.com>


Compare: https://github.com/lxc/lxc/compare/844f7a387484...6eaac3034e8c