[lxc-devel] [PATCH] Remove lxc-verison, lxc-ps and lxc-netstat

Dwight Engen dwight.engen at oracle.com
Wed Jan 22 18:22:31 UTC 2014


On Tue, 21 Jan 2014 12:24:04 -0500
Stéphane Graber <stgraber at ubuntu.com> wrote:

> lxc-ps and lxc-netstat have an unfortunate tendency to break every so
> often, produce mostly unreadable output and should be replaced by a
> lxc-attach call in 99% of the cases.
> 
> In an effort to cleanup the lxc-* namespace, I think those two should
> go, so this patch gets rid of them as well as any reference to them in
> our documentation.
> 
> I also think that lxc-version should disappear as it's only a one line
> shell script printing the version string, so having a whole command
> just for that seems to be a bit of a waste.
> 
> Instead, this patch introduces a new --version common option which all
> binaries will automatically inherit and that'll print LXC_VERSION on
> stdout and exit 0.

I like this much better than having a one line shell script, so I agree
it can go. I've been working on the lxc native OpenStack driver [1] a
bit, fixing up some bugs etc... and did notice that it uses the
existence of lxc-version to know if lxc is installed or not. Not a big
deal to change, but thought I'd note it. I guess if we cared about
leaving lxc-version it could just be a shell script that does lxc-start
--version or something.

[1] https://code.launchpad.net/~zulcss/nova/lxc/+merge/187796


More information about the lxc-devel mailing list