[lxc-devel] [PATCH] make lxcapi_get_interfaces and lxcapi_get_ips unprivileged container aware

[S.Çağlar Onur]

On Tue, Jan 21, 2014 at 11:38 PM, Serge Hallyn <serge.hallyn at ubuntu.com> wrote:
> Quoting Stéphane Graber (stgraber at ubuntu.com):
>> On Tue, Jan 21, 2014 at 09:36:06PM -0500, S.Çağlar Onur wrote:
>> > On Tue, Jan 21, 2014 at 6:41 PM, Serge Hallyn <serge.hallyn at ubuntu.com> wrote:
>> > > Quoting S.Çağlar Onur (caglar at 10ur.org):
>> > >> Based on Stéphane's suggestion, those two API methods now;
>> > >>
>> > >> * fork a new process,
>> > >> * switch to appropriate namespace(s),
>> > >> * do what we want,
>> > >> * return the data over a pipe to the parent which returns the result to the original caller.
>> > >>
>> > >> For the whole thread please see;
>> > >>
>> > >>  https://lists.linuxcontainers.org/pipermail/lxc-devel/2014-January/007362.html
>> > >>
>> > >> This patch also makes lxc-ls and lxc-info call those functions.
>> > >>
>> > >> I'm adding Stéphane as an author here since both the idea as well as
>> > >> the initial setns code come from him.
>> > >>
>> > >> Author: S.Çağlar Onur <caglar at 10ur.org>
>> > >> Author: Stéphane Graber <stgraber at ubuntu.com>
>> > >> Signed-off-by: S.Çağlar Onur <caglar at 10ur.org>
>> > >
>> > > Thanks, looks good except for two issues below.  With those fixed,
>> > >
>> > > Acked-by: Serge E. Hallyn <serge.hallyn at ubuntu.com>
>> >
>> > I believe Stéphane fixed them while pushing :)
>>
>> I did indeed and also updated the ERROR messages to be a bit more
>> relevant (they were mentioning template creation).
>
> Great, thanks guys.  I"ll figure out what's going on with
> unprivileged lxc-start using cgmanager tomorrow.

Thanks Serge, if it helps it looks like cgroup_settings variable in
setup_limits at src/lxc/cgmanager.c fails at lxc_list_empty test but I
couldn't figured out why.

> -serge
> _______________________________________________
> lxc-devel mailing list
> lxc-devel at lists.linuxcontainers.org
> http://lists.linuxcontainers.org/listinfo/lxc-devel

-- 
S.Çağlar Onur <caglar at 10ur.org>