[lxc-devel] [lxc/lxc] d4ef7c: Initial support for cgmanager

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: d4ef7c50ae980d13f6e7a44c595228a8cba9d8f2
      https://github.com/lxc/lxc/commit/d4ef7c50ae980d13f6e7a44c595228a8cba9d8f2
  Author: Serge Hallyn <serge.hallyn at ubuntu.com>
  Date:   2014-01-15 (Wed, 15 Jan 2014)

  Changed paths:
    M configure.ac
    M src/lxc/Makefile.am
    M src/lxc/attach.c
    A src/lxc/cgmanager.c
    M src/lxc/cgroup.c
    M src/lxc/cgroup.h
    M src/lxc/commands.c
    M src/lxc/conf.c
    M src/lxc/conf.h
    M src/lxc/freezer.c
    M src/lxc/lxc.h
    M src/lxc/start.c
    M src/lxc/start.h

  Log Message:
  -----------
  Initial support for cgmanager

This patch splits out most of the cgroupfs-specific code, so that
cgroup-manager versions can be plugged in.  The case I did
not handle is cgroup_enter at lxc_attach.  I'm hoping that case can
be greatly simplified, but will worry about it after fleshing out the
cgroup manager handlers.

This also simplify the freezer functions.

This seems to not regress my common tests when running without
cgmanager, but I'd like to do a bit more testing before pushing.
However I was hoping to get some more eyes on this so am sending it
out now.

Signed-off-by: Serge Hallyn <serge.hallyn at ubuntu.com>
Acked-by: Stéphane Graber <stgraber at ubuntu.com>


  Commit: 6873d6f078d801c36948c2e63c3fc8f58812aeea
      https://github.com/lxc/lxc/commit/6873d6f078d801c36948c2e63c3fc8f58812aeea
  Author: Serge Hallyn <serge.hallyn at ubuntu.com>
  Date:   2014-01-15 (Wed, 15 Jan 2014)

  Changed paths:
    M src/lxc/cgmanager.c

  Log Message:
  -----------
  implement cgmanager_remove_cgroup

Signed-off-by: Serge Hallyn <serge.hallyn at ubuntu.com>
Acked-by: Stéphane Graber <stgraber at ubuntu.com>


  Commit: 0086f49995a77fe66ad7573834c941ca5d24f4d2
      https://github.com/lxc/lxc/commit/0086f49995a77fe66ad7573834c941ca5d24f4d2
  Author: Serge Hallyn <serge.hallyn at ubuntu.com>
  Date:   2014-01-15 (Wed, 15 Jan 2014)

  Changed paths:
    M src/lxc/cgmanager.c
    M src/lxc/cgroup.c
    M src/lxc/cgroup.h
    M src/lxc/commands.c

  Log Message:
  -----------
  stop cmd callback: unfreeze by path only

in particular, regular unfreeze uses the cmd api to request the cgroup
of the container.  If we are already in the lxc-start monitor, we can't
use the cmd api.

(I knew when I started this would be a problem but then as it didn't
reliably crash, I forgot to handle it)

Signed-off-by: Serge Hallyn <serge.hallyn at ubuntu.com>
Acked-by: Stéphane Graber <stgraber at ubuntu.com>


Compare: https://github.com/lxc/lxc/compare/9cde0368fbbf...0086f49995a7