[lxc-devel] [PATCH 1/1] Initial support for cgmanager

Serge Hallyn serge.hallyn at ubuntu.com
Wed Jan 15 17:19:41 UTC 2014


Quoting Stéphane Graber (stgraber at ubuntu.com):
> On Tue, Jan 14, 2014 at 04:41:36PM -0600, Serge Hallyn wrote:
> > This patch splits out most of the cgroupfs-specific code, so that
> > cgroup-manager versions can be plugged in.  The case I did
> > not handle is cgroup_enter at lxc_attach.  I'm hoping that case can
> > be greatly simplified, but will worry about it after fleshing out the
> > cgroup manager handlers.
> > 
> > This also simplify the freezer functions.
> > 
> > This seems to not regress my common tests when running without
> > cgmanager, but I'd like to do a bit more testing before pushing.
> > However I was hoping to get some more eyes on this so am sending it
> > out now.
> > 
> > Signed-off-by: Serge Hallyn <serge.hallyn at ubuntu.com>
> 
> So I haven't spotted anything obviously wrong with it, besides the few
> functions that are currently marked as unimplemented.

> I also confirmed that the code still builds on all supported platforms
> (without cgmanager), so if it breaks the existing code path, it doesn't
> do so in any obvious way.

All my testing currently seems to be passing (using cgroupfs driver).
Ideally I'd like to get wider testing.  Can anyone suggest a better way
than for me to simply push the patch upstream?

-serge


More information about the lxc-devel mailing list