[lxc-devel] [PATCH] cgroup.c: redefine the valid cgroup name

Qiang Huang h.huangqiang at huawei.com
Wed Jan 15 04:09:26 UTC 2014


Signed-off-by: Qiang Huang <h.huangqiang at huawei.com>
---
 src/lxc/cgroup.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/lxc/cgroup.c b/src/lxc/cgroup.c
index 6d837f9..69910cc 100644
--- a/src/lxc/cgroup.c
+++ b/src/lxc/cgroup.c
@@ -1669,7 +1669,11 @@ bool is_valid_cgroup(const char *name)
 {
 	const char *p;
 	for (p = name; *p; p++) {
-		if (*p < 32 || *p == 127 || *p == '/')
+		/* Use the ASCII printable characters range(32 - 127)
+		 * is reasonable, we kick out 32(SPACE) because it'll
+		 * break legacy lxc-ls
+		 */
+		if (*p <= 32 || *p >= 127 || *p == '/')
 			return false;
 	}
 	return strcmp(name, ".") != 0 && strcmp(name, "..") != 0;
-- 
1.8.3



More information about the lxc-devel mailing list