[lxc-devel] [PATCH] gentoo template (updated network management, master rebase)

[lxc at zitta.fr]

Le 14/01/2014 23:40, Stéphane Graber a écrit :
> On Tue, Jan 14, 2014 at 11:34:19PM +0100, lxc at zitta.fr wrote:
>> Le 14/01/2014 22:42, Stéphane Graber a écrit :
>>> On Tue, Jan 14, 2014 at 12:06:26AM +0100, lxc at zitta.fr wrote:
>>>> Gentoo template
>>>>
>>>> Signed-off-by: gza <lxc at zitta.fr>
>>> Hi,
>>>
>>> I must admit having only very briefly gone through the code as I'm not
>>> familiar with Gentoo and it's a rather massive template to do a full
>>> review of.
>>>
>>> I just noticed you're missing a .gitignore entry which I'll add and it's
>>> also unfortunate that a new template isn't using the new common config
>>> includes instead of hardcoding the whole config into every single
>>> container, but that's something you'll obviously fix in the near future.
>>>
>>>
>>> In the meant time:
>>> Acked-by: Stéphane Graber <stgraber at ubuntu.com>
>> Hi, I'll try to apply best practices during next days.
>>
>> BTW, What about common "bash functions" for templates ?
>> Perhaps for Lxc 1.1 ...
> It's been mentioned a few times but apparently nobody actually did that yet.
> Adding a new lxc-templates.functions with standard shell functions for
> template to use would make a lot of sense to me.
I'll do proposals ... after 1.0
> Btw, I forgot to comment on that earlier, you say:
>>>> +    #I'll drink champagne the day we do templates in python
>>>> +    #let's do some drity bash things
> Well, there's actually no reason why you couldn't have written your
> template in python. It's just a coincidence that everyone so far has
> been using either POSIX shell or bash for their templates. LXC simply
> expects a standard set of arguments to be accepted by the template and
> have it exit 1 on error and 0 on success.
Yep, perhaps you're right, perhaps shell was chosen when templates where simple :)
In the other hand, all we do with sed, mkdirs, chroots, etc... may be very difficult in python.

Anyway, this comment should not be left and will be removed.

Thanks for all.