[lxc-devel] [PATCH] ensure all config items are duplicated on clone/write_config

[Dwight Engen]

On Fri, 10 Jan 2014 16:59:31 -0600
Serge Hallyn <serge.hallyn at ubuntu.com> wrote:

> Quoting Dwight Engen (dwight.engen at oracle.com):
> > Since previously I had found a config item that wasn't being
> > propagated by lxc-clone, I went through all the config items and
> > made sure that: a) Each item is documented in lxc.conf
> >  b) Each item is written out by write_config
> > 
> > The only one that isn't is lxc.include, which by its nature only
> > pulls in other config item types.
> > 
> > Signed-off-by: Dwight Engen <dwight.engen at oracle.com>
> 
> Acked-by: Serge E. Hallyn <serge.hallyn at ubuntu.com>
> 
> But one question - should we skip the autostart settings for
> lxc-clone (somehow)?  Consider that lxcapi_clone is used by
> lxcapi_snapshot.  If I create 10 snapshots of my mail server
> I don't want 11 mail servers started on my next boot :)

Hey Serge, I hadn't considered the snapshot case, but I did wonder if
we wanted to preserve autostart for clones. I think so, because
otherwise 'clone' wouldn't really be clone. If the user wants the
cloned container to differ, then I think it is up to them to change
it. Luckily Stéphane had the foresight to have autostart ignore
snapshots :)