[lxc-devel] [PATCH] Setting lxc.console = none causes startup failures for the containers that runs in user namespace

[Serge Hallyn]

Quoting S.Çağlar Onur (caglar at 10ur.org):
> Setting "lxc.console = none" causes following failure during startup
> 
>       lxc-start 1389039861.061 INFO     lxc_start_ui - using rcfile lxcpath/original/config
>       lxc-start 1389039861.062 INFO     lxc_confile - read uid map: type u nsid 0 hostid 260000 range 10000
>       lxc-start 1389039861.062 INFO     lxc_confile - read uid map: type g nsid 0 hostid 260000 range 10000
>       lxc-start 1389039861.062 WARN     lxc_log - lxc_log_init called with log already initialized
>       lxc-start 1389039861.065 INFO     lxc_lsm - LSM security driver AppArmor
>       lxc-start 1389039861.066 DEBUG    lxc_conf - allocated pty '/dev/pts/0' (5/6)
>       lxc-start 1389039861.066 DEBUG    lxc_conf - allocated pty '/dev/pts/7' (7/8)
>       lxc-start 1389039861.066 DEBUG    lxc_conf - allocated pty '/dev/pts/8' (9/10)
>       lxc-start 1389039861.066 DEBUG    lxc_conf - allocated pty '/dev/pts/9' (11/12)
>       lxc-start 1389039861.066 INFO     lxc_conf - tty's configured
>       lxc-start 1389039861.066 DEBUG    lxc_start - sigchild handler set
>       lxc-start 1389039861.066 ERROR    lxc_conf - Error chowning
>       lxc-start 1389039861.066 ERROR    lxc_conf - Failed to chown
>       lxc-start 1389039861.066 ERROR    lxc_start - Failed to shift tty into container
>       lxc-start 1389039861.066 ERROR    lxc_start - failed to initialize the container
>       lxc-start 1389039861.067 INFO     lxc_monitor - using monitor sock name lxc/0863ffed81827105/lxcpath
> 
> fix it by checking the console.name before using it.
> 
> Signed-off-by: S.Çağlar Onur <caglar at 10ur.org>

Acked-by: Serge E. Hallyn <serge.hallyn at ubuntu.com>

> ---
>  src/lxc/conf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/lxc/conf.c b/src/lxc/conf.c
> index b7a6ae3..a386d94 100644
> --- a/src/lxc/conf.c
> +++ b/src/lxc/conf.c
> @@ -3368,7 +3368,7 @@ int ttys_shift_ids(struct lxc_conf *c)
>  		}
>  	}
>  
> -	if (chown_mapped_root(c->console.name, c) < 0) {
> +	if (strcmp(c->console.name, "") !=0 && chown_mapped_root(c->console.name, c) < 0) {
>  		ERROR("Failed to chown %s", c->console.name);
>  		return -1;
>  	}
> -- 
> 1.8.3.2
> 
> _______________________________________________
> lxc-devel mailing list
> lxc-devel at lists.linuxcontainers.org
> http://lists.linuxcontainers.org/listinfo/lxc-devel