[lxc-devel] [lxc/lxc] 1d1678: lxc-start: close inherited fds right before exec

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 1d1678579977851976543585104c269bda5ce719
      https://github.com/lxc/lxc/commit/1d1678579977851976543585104c269bda5ce719
  Author: Serge Hallyn <serge.hallyn at ubuntu.com>
  Date:   2014-02-14 (Fri, 14 Feb 2014)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  lxc-start: close inherited fds right before exec

Not before we've even forked.

Signed-off-by: Serge Hallyn <serge.hallyn at ubuntu.com>
Acked-by: Stéphane Graber <stgraber at ubuntu.com>


  Commit: 7eb44573b01b70b21bd007ab3f917e56a2a555d4
      https://github.com/lxc/lxc/commit/7eb44573b01b70b21bd007ab3f917e56a2a555d4
  Author: Serge Hallyn <serge.hallyn at ubuntu.com>
  Date:   2014-02-14 (Fri, 14 Feb 2014)

  Changed paths:
    M src/lxc/cgmanager.c
    M src/lxc/cgroup.c
    M src/lxc/cgroup.h
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  re-open cgmanager socket after fork in daemonized start

Signed-off-by: Serge Hallyn <serge.hallyn at ubuntu.com>
Acked-by: Stéphane Graber <stgraber at ubuntu.com>


  Commit: 9de2ebe99503be25dee9ef327e9e16d3ed85fc5d
      https://github.com/lxc/lxc/commit/9de2ebe99503be25dee9ef327e9e16d3ed85fc5d
  Author: Stéphane Graber <stgraber at ubuntu.com>
  Date:   2014-02-14 (Fri, 14 Feb 2014)

  Changed paths:
    M src/lxc/console.c
    M src/lxc/lxcutmp.c

  Log Message:
  -----------
  coverity: Check fread length

Signed-off-by: Stéphane Graber <stgraber at ubuntu.com>
Acked-by: Serge E. Hallyn <serge.hallyn at ubuntu.com>


  Commit: bdcb7aa9ed4f15fe1275ac375918cfa6c8860c6f
      https://github.com/lxc/lxc/commit/bdcb7aa9ed4f15fe1275ac375918cfa6c8860c6f
  Author: Stéphane Graber <stgraber at ubuntu.com>
  Date:   2014-02-14 (Fri, 14 Feb 2014)

  Changed paths:
    M src/lxc/lxc_attach.c

  Log Message:
  -----------
  coverity: Silence potential null-deref warning

Signed-off-by: Stéphane Graber <stgraber at ubuntu.com>
Acked-by: Serge E. Hallyn <serge.hallyn at ubuntu.com>


  Commit: 1e98542850b1747138c899edd61ecbe43ff3ed55
      https://github.com/lxc/lxc/commit/1e98542850b1747138c899edd61ecbe43ff3ed55
  Author: Stéphane Graber <stgraber at ubuntu.com>
  Date:   2014-02-14 (Fri, 14 Feb 2014)

  Changed paths:
    M src/lxc/lxc_user_nic.c

  Log Message:
  -----------
  coverity: Check fstat return value

Signed-off-by: Stéphane Graber <stgraber at ubuntu.com>
Acked-by: Serge E. Hallyn <serge.hallyn at ubuntu.com>


  Commit: acd4922efe82a3b9d83eb231cd227fc322be8363
      https://github.com/lxc/lxc/commit/acd4922efe82a3b9d83eb231cd227fc322be8363
  Author: Stéphane Graber <stgraber at ubuntu.com>
  Date:   2014-02-14 (Fri, 14 Feb 2014)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  coverity: Check return value of setenv

Signed-off-by: Stéphane Graber <stgraber at ubuntu.com>
Acked-by: Serge E. Hallyn <serge.hallyn at ubuntu.com>


  Commit: 71b2940d87135239762951024557e51a58b8224b
      https://github.com/lxc/lxc/commit/71b2940d87135239762951024557e51a58b8224b
  Author: Stéphane Graber <stgraber at ubuntu.com>
  Date:   2014-02-14 (Fri, 14 Feb 2014)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  coverity: Check fcntl return value

Signed-off-by: Stéphane Graber <stgraber at ubuntu.com>
Acked-by: Serge E. Hallyn <serge.hallyn at ubuntu.com>


  Commit: 9f3d75a0ca34c78f94227a59905fbd7b59355826
      https://github.com/lxc/lxc/commit/9f3d75a0ca34c78f94227a59905fbd7b59355826
  Author: Stéphane Graber <stgraber at ubuntu.com>
  Date:   2014-02-14 (Fri, 14 Feb 2014)

  Changed paths:
    M src/tests/locktests.c

  Log Message:
  -----------
  coverity: Don't pass uninitialized var to write

Signed-off-by: Stéphane Graber <stgraber at ubuntu.com>
Acked-by: Serge E. Hallyn <serge.hallyn at ubuntu.com>


Compare: https://github.com/lxc/lxc/compare/93c379f09ce6...9f3d75a0ca34