[lxc-devel] [PATCH] lxc-plamo: various small changes

Serge Hallyn serge.hallyn at ubuntu.com
Fri Feb 7 17:40:23 UTC 2014


Quoting KATOH Yasufumi (karma at jazz.email.ne.jp):
> > > - Change redirection of fd 200 to 9
> > Why?
> 
> "man bash" says:
> | Redirections  using file descriptors greater than 9 should be used with
> | care, as they may conflict with file descriptors the shell uses  inter-
> | nally.

Yup, I stand corrected.  That piece is worthwhile.  (Please give a
few words justifying such changes in the patch description when you
can :)

> > >  configure_plamo() {
> > > @@ -215,7 +215,7 @@ configure_plamo() {
> > >  	EOF
> > >    # /etc/rc.d/rc.M
> > >    ed - $rootfs/etc/rc.d/rc.M <<- "EOF"
> > > -	269,270d
> > > +	280,281d
> 
> > This seems needlessly fragile.  
> 
> I think so too. :-)

Do you have a plan for avoiding it in the future?  Are you one of
the plamo upstream contributors, would checking for container=lxc
be feasible/acceptable?

-serge


More information about the lxc-devel mailing list