[lxc-devel] lxc.id_map bug when writing directly to /proc/pid/[ug]id_map [PATCH]

Miquel van Smoorenburg mikevs at xs4all.net
Thu Feb 6 17:00:14 UTC 2014


On 06/02/14 05:36, Serge Hallyn wrote:
> Quoting Miquel van Smoorenburg (mikevs at xs4all.net):
>> lxc.id_map bug when writing directly to /proc/pid/[ug]id_map
>>
>> There's some code in src/lxc/conf.c that sets up the UID/GID mapping. It
>> can use the external newuidmap/newgidmap tools, or it can write to
>> /proc/pid/[ug]id_map directly. The latter case is broken: lines are written
>> without a newline (\n) at the end. This patch fixes that. Note that
>> I did not check if the newuidmap/newgidmap case still works. It should,
>> but I wasn't able to test it.
>>
>> Signed-off-by: Miquel van Smoorenburg <mikevs at xs4all.net>
>
> Odd, I thought I had already pushed this patch a few weeks ago?

Well I initially posted it to the bugtracker and you asked me resend it 
with a Signed-off-by as either a git pull request or a patch, and it 
took me a while to actually do this.

Mike.


More information about the lxc-devel mailing list