[lxc-devel] [PATCH] lxc-opensuse: Disable building openSUSE containers on 13.2/Tumbleweed only if wrong version of build package is installed (was: [PATCH] Disabled building openSUSE containers on openSUSE 13.2 and openSUSE Tumbleweed due to faulty behaviour with newer versions of init_buildsystem)

[Stéphane Graber]

On Wed, Dec 17, 2014 at 09:06:34PM +0100, Johannes Kastl wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 27.11.2014 Stéphane Graber wrote:
> 
> > There is a bug report, but no solution yet. I am busy with other 
> > real world stuff right now, so maybe to protect users this patch 
> > should make it into stable-1.0?
> 
> The bug has been found, it was a different behaviour in the build
> package. This is fixed on openSUSE with build version 20141120 or newer.
> 
> So, I changed the version check in the package, and it aborts creation
> only if
> - - running on openSUSE 13.2 or Tumbleweed
> AND
> - - the version of the build package is lower than 20141120.
> 
> This patch is for stable-1.0, I'd like to get this into 1.1, too. I'll
> send a patch soon.
> 
> Regards,
> Johannes
> - -- 
> I love deadlines. I like the whooshing sound they make as they fly by.
> (Douglas Adams)
> 
> -----BEGIN PGP SIGNATURE-----
> Comment: Using GnuPG with SeaMonkey - http://www.enigmail.net/
> 
> iEYEARECAAYFAlSR4koACgkQzi3gQ/xETbKL7ACfYR+l0a5/poqlGJEZgIQRBpkY
> eMQAniDNjJUMUb7v/L6S/ugyecbYyLQT
> =LXRW
> -----END PGP SIGNATURE-----

> From 14ad06d6beb245dcfa59cb940f95e47ebcc05d02 Mon Sep 17 00:00:00 2001
> From: Johannes Kastl <git at ojkastl.de>
> Date: Wed, 17 Dec 2014 21:01:27 +0100
> Subject: [PATCH] lxc-opensuse: Disable building openSUSE containers on
>  13.2/Tumbleweed only if wrong version of build package is installed
> 
> Signed-off-by: Johannes Kastl <git at ojkastl.de>

Acked-by: Stéphane Graber <stgraber at ubuntu.com>

> ---
>  templates/lxc-opensuse.in | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/templates/lxc-opensuse.in b/templates/lxc-opensuse.in
> index c593238..8d1d4e1 100644
> --- a/templates/lxc-opensuse.in
> +++ b/templates/lxc-opensuse.in
> @@ -395,8 +395,10 @@ if [ -z "$path" ]; then
>  fi
>  
>  if grep -q Harlequin /etc/os-release || grep -q Tumbleweed /etc/os-release ; then
> -    echo "Building containers on openSUSE 13.2 or Tumbleweed is broken at the moment. We are working on this problem."
> -    exit 1
> +    if [[ "$(zypper info build|awk -F "[- ]" '/Version/ {print $2}')" -lt "20141120" ]] ; then
> +	echo "Building openSUSE containers with your version of the build package is broken. Please install the update to version 20141120 or newer."
> +	exit 1
> +    fi
>  fi
>  
>  if [ "$(id -u)" != "0" ]; then
> -- 
> 2.2.0
> 

> _______________________________________________
> lxc-devel mailing list
> lxc-devel at lists.linuxcontainers.org
> http://lists.linuxcontainers.org/listinfo/lxc-devel


-- 
Stéphane Graber
Ubuntu developer
http://www.ubuntu.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20141219/d968ed0c/attachment.sig>