[lxc-devel] [lxc/lxc] e5e0bc: tests: try again when waitpid() sets errno as EINT...

GitHub noreply at github.com
Thu Dec 4 20:30:07 UTC 2014


  Branch: refs/heads/stable-1.0
  Home:   https://github.com/lxc/lxc
  Commit: e5e0bc557a2aabb8b1173144ba602b7b874dc9ab
      https://github.com/lxc/lxc/commit/e5e0bc557a2aabb8b1173144ba602b7b874dc9ab
  Author: Arjun Sreedharan <arjun024 at gmail.com>
  Date:   2014-12-04 (Thu, 04 Dec 2014)

  Changed paths:
    M src/tests/containertests.c
    M src/tests/destroytest.c
    M src/tests/saveconfig.c
    M src/tests/startone.c

  Log Message:
  -----------
  tests: try again when waitpid() sets errno as EINTR

when waitpid() is interrupted, errno is not set to the negative
value -EINTR. It is set to EINTR. check against EINTR.

Signed-off-by: Arjun Sreedharan <arjun024 at gmail.com>
Acked-by: Stéphane Graber <stgraber at ubuntu.com>


  Commit: dc990b1d9f26cd860ee9cf49034e36fe63ba76b2
      https://github.com/lxc/lxc/commit/dc990b1d9f26cd860ee9cf49034e36fe63ba76b2
  Author: Shuai Zhang <zs.broccoli at gmail.com>
  Date:   2014-12-04 (Thu, 04 Dec 2014)

  Changed paths:
    M src/lxc/network.c
    M src/lxc/nl.c
    M src/lxc/nl.h

  Log Message:
  -----------
  audit: added capacity and reserve() to nlmsg

There are now two (permitted) ways to add data to netlink message:

 1. put_xxx()
 2. call nlmsg_reserve() to get a pointer to newly reserved room within the
    original netlink message, then write or memcpy data to that area.

Both of them guarantee adding requested length data do not overflow the
pre-allocated message buffer by checking against its cap field first.

And there may be no need to access nlmsg_len outside nl module, because both
put_xxx() and nlmsg_reserve() have alread did that for us.

Signed-off-by: Shuai Zhang <zs.broccoli at gmail.com>
Acked-by: Stéphane Graber <stgraber at ubuntu.com>


  Commit: 53ae2e9240eb1d7182e1366ee735014ecd36f133
      https://github.com/lxc/lxc/commit/53ae2e9240eb1d7182e1366ee735014ecd36f133
  Author: S.Çağlar Onur <caglar at 10ur.org>
  Date:   2014-12-04 (Thu, 04 Dec 2014)

  Changed paths:
    M src/lxc/bdev.c
    M src/lxc/log.c

  Log Message:
  -----------
  rmdir and lxc_unpriv returns non-negative error codes

Signed-off-by: S.Çağlar Onur <caglar at 10ur.org>
Acked-by: Stéphane Graber <stgraber at ubuntu.com>


Compare: https://github.com/lxc/lxc/compare/a44cafdb091f...53ae2e9240eb


More information about the lxc-devel mailing list