[lxc-devel] [lxc/lxc] 21e624: tests: try again when waitpid() sets errno as EINT...

GitHub noreply at github.com
Thu Dec 4 16:50:07 UTC 2014


  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 21e624d9cf79d05179030f1534552048e0c506f5
      https://github.com/lxc/lxc/commit/21e624d9cf79d05179030f1534552048e0c506f5
  Author: Arjun Sreedharan <arjun024 at gmail.com>
  Date:   2014-12-04 (Thu, 04 Dec 2014)

  Changed paths:
    M src/tests/containertests.c
    M src/tests/destroytest.c
    M src/tests/saveconfig.c
    M src/tests/startone.c

  Log Message:
  -----------
  tests: try again when waitpid() sets errno as EINTR

when waitpid() is interrupted, errno is not set to the negative
value -EINTR. It is set to EINTR. check against EINTR.

Signed-off-by: Arjun Sreedharan <arjun024 at gmail.com>
Acked-by: Stéphane Graber <stgraber at ubuntu.com>


  Commit: 06f976cad74d027c8080b594eefb391298b4c341
      https://github.com/lxc/lxc/commit/06f976cad74d027c8080b594eefb391298b4c341
  Author: Shuai Zhang <zs.broccoli at gmail.com>
  Date:   2014-12-04 (Thu, 04 Dec 2014)

  Changed paths:
    M src/lxc/network.c
    M src/lxc/nl.c
    M src/lxc/nl.h

  Log Message:
  -----------
  audit: added capacity and reserve() to nlmsg

There are now two (permitted) ways to add data to netlink message:

 1. put_xxx()
 2. call nlmsg_reserve() to get a pointer to newly reserved room within the
    original netlink message, then write or memcpy data to that area.

Both of them guarantee adding requested length data do not overflow the
pre-allocated message buffer by checking against its cap field first.

And there may be no need to access nlmsg_len outside nl module, because both
put_xxx() and nlmsg_reserve() have alread did that for us.

Signed-off-by: Shuai Zhang <zs.broccoli at gmail.com>
Acked-by: Stéphane Graber <stgraber at ubuntu.com>


Compare: https://github.com/lxc/lxc/compare/d2928eafbbba...06f976cad74d


More information about the lxc-devel mailing list