[lxc-devel] [PATCH 1/6] Move lxcbr0 setup logic into lxc.net script

[Martin Pitt]

Hey Serge,

Serge Hallyn [2014-07-31 17:46 +0000]:
> Note there is no Signed-off-by line here.  (git commit -s will add one)

Right, do you need one? I'm already the Author:, so signing off my own
commits seems a little redundant?

> Now, if we're going to move this out of upstart, should we be putting
> in full paths for all of the commands?  Who knows how admins will get to
> the script...

Not sure what you mean here, you mean the full path for things like
iptables, brctl, dnsmasq? I really wouldn't want to do that -- that
would make the script highly platform dependant and break the
possibility of using /usr/local/bin etc.

For an upstart context this doesn't change anything -- the upstart
job has a default $PATH set which gets inherited by calling lxc.net
from the job:

> > +pre-start exec /usr/share/lxc/lxc.net start
> > +post-stop exec /usr/share/lxc/lxc.net stop

For systemd units it is similar. At least it works fine under a
Debian/Ubuntu context, I haven't tested it under Fedora; but it would
be weird if their tools wouldn't be in $PATH for the root user?

Thanks,

Martin

-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20140801/ddf64296/attachment.sig>