[lxc-devel] [PATCH 1/1] snapshots: move snapshot directory

[Serge Hallyn]

Quoting Stéphane Graber (stgraber at ubuntu.com):
> On Wed, Apr 30, 2014 at 08:29:14PM +0000, John Peacock wrote:
> > On Wed, 2014-04-30 at 20:25 +0000, Serge Hallyn wrote:
> > > I was wanting to keep them out of the container itself, but I
> > > can't really make a good case for wanting that.  So +1, let's
> > > do that - if someone else wants to write the patch before I get to
> > > it, shout.
> > 
> > I think the benefit of having all of the snapshots in one place is
> > greatly outweighed by the convenience of having all of the snapshots for
> > this container in one place, associated with the container itself.  It
> > should also make it easier to completely remove a container AND its
> > snapshots.  Having the snapshots someplace else makes it more likely to
> > get forgotten unless lxc nags you to delete the snapshots when you
> > delete the image.
> > 
> > Thanks
> > 
> > John
> 
> Right, I pretty often move containers from one box to another, so having
> everything nicely contained within the container dir makes that very
> easy. We finally got rid of the auto-start flags in /etc so also moving
> the snapshots to the container dir would make things pretty much perfect
> I think.

Heh, well right now snapshot restore is done by deleting the original
and then cloneing the desired snapshot - so that will require some
care to not delete all the snapshots while we're removing the original
container :)