[lxc-devel] [lxc/lxc] debfa8: cppcheck: fix unchecked realloc in lxc_info.c

GitHub noreply at github.com
Wed Apr 30 19:59:17 UTC 2014 

  Branch: refs/heads/stable-1.0
  Home:   https://github.com/lxc/lxc
  Commit: debfa8b6159fcd42ff562e0f4630bed95e974fa9
      https://github.com/lxc/lxc/commit/debfa8b6159fcd42ff562e0f4630bed95e974fa9
  Author: Serge Hallyn <serge.hallyn at ubuntu.com>
  Date:   2014-04-30 (Wed, 30 Apr 2014)

  Changed paths:
    M src/lxc/lxc_info.c

  Log Message:
  -----------
  cppcheck: fix unchecked realloc in lxc_info.c

Signed-off-by: Serge Hallyn <serge.hallyn at ubuntu.com>
Acked-by: Stéphane Graber <stgraber at ubuntu.com>


  Commit: 0c0bc69c205cf97e74ba30b794230ff5a2108d60
      https://github.com/lxc/lxc/commit/0c0bc69c205cf97e74ba30b794230ff5a2108d60
  Author: Serge Hallyn <serge.hallyn at ubuntu.com>
  Date:   2014-04-30 (Wed, 30 Apr 2014)

  Changed paths:
    M doc/lxc-clone.sgml.in

  Log Message:
  -----------
  lxc-clone man page: fix typos

In the body of the manpage, replace a few errant 'fssize's with the
more appropriate word.

Reported-by: MegaBrutal <megabrutal at megabrutal.com>
Signed-off-by: Serge Hallyn <serge.hallyn at ubuntu.com>


  Commit: a76de6bd071b6ec36babde7a938338eb0497c90d
      https://github.com/lxc/lxc/commit/a76de6bd071b6ec36babde7a938338eb0497c90d
  Author: Serge Hallyn <serge.hallyn at ubuntu.com>
  Date:   2014-04-30 (Wed, 30 Apr 2014)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  lxc startup: manually mark every shared mount entry as slave

If you 'ip netns add x1', this creates /run/netns and /run/netns/x1
as shared mounts.  When a container starts, it umounts these after
pivot_root, and the umount is propagated to the host.

Worse, doing mount("", "/", NULL, MS_SLAVE|MS_REC, NULL) does not
suffice to change those, even after binding /proc/mounts onto
/etc/mtab.

So, I give up.  Do this manually, walking over /proc/self/mountinfo
and changing the mount propagation on everything marked as shared.

With this patch, lxc-start no longer unmounts /run/netns/* on the
host.

Signed-off-by: Serge Hallyn <serge.hallyn at ubuntu.com>


  Commit: 9a3cf18cea4f1b45a07942acee809f67fc8b499d
      https://github.com/lxc/lxc/commit/9a3cf18cea4f1b45a07942acee809f67fc8b499d
  Author: Michael H. Warfield <mhw at WittsEnd.com>
  Date:   2014-04-30 (Wed, 30 Apr 2014)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  Check for symlinks before attempting create.

Check for symlinks before attempting create.

When attempting to create the compulsory symlinks in /dev,
check for the existence of the link using stat first before
blindly attempting to create the link.

This works around an apparent quirk in the kernel VFS on read-only
file systems where the returned error code might be EEXIST or EROFS
depending on previous access to the /dev directory and its entries.

Reported-by: William Dauchy <william at gandi.net>
Signed-off-by: Michael H. Warfield <mhw at WittsEnd.com>
Tested-by: William Dauchy <william at gandi.net>


  Commit: 9ccb0c8a5cf814f9b7fb7bfea635aaa444a6cb02
      https://github.com/lxc/lxc/commit/9ccb0c8a5cf814f9b7fb7bfea635aaa444a6cb02
  Author: Dwight Engen <dwight.engen at oracle.com>
  Date:   2014-04-30 (Wed, 30 Apr 2014)

  Changed paths:
    M src/lxc/monitor.c

  Log Message:
  -----------
  coverity: fix fd leak in error case (1011105)

I inadvertently introduced this with commit 8bf1e61e.

Signed-off-by: Dwight Engen <dwight.engen at oracle.com>
Signed-off-by: Serge Hallyn <serge.hallyn at ubuntu.com>


  Commit: aa516f49845906537738394ed705f8d11a795434
      https://github.com/lxc/lxc/commit/aa516f49845906537738394ed705f8d11a795434
  Author: KATOH Yasufumi <karma at jazz.email.ne.jp>
  Date:   2014-04-30 (Wed, 30 Apr 2014)

  Changed paths:
    M doc/ja/common_options.sgml.in
    M doc/ja/legacy/lxc-ls.sgml.in
    M doc/ja/lxc-attach.sgml.in
    M doc/ja/lxc-autostart.sgml.in
    M doc/ja/lxc-cgroup.sgml.in
    M doc/ja/lxc-checkconfig.sgml.in
    M doc/ja/lxc-clone.sgml.in
    M doc/ja/lxc-config.sgml.in
    M doc/ja/lxc-console.sgml.in
    M doc/ja/lxc-create.sgml.in
    M doc/ja/lxc-destroy.sgml.in
    M doc/ja/lxc-device.sgml.in
    M doc/ja/lxc-execute.sgml.in
    M doc/ja/lxc-freeze.sgml.in
    M doc/ja/lxc-info.sgml.in
    M doc/ja/lxc-ls.sgml.in
    M doc/ja/lxc-monitor.sgml.in
    M doc/ja/lxc-snapshot.sgml.in
    M doc/ja/lxc-start-ephemeral.sgml.in
    M doc/ja/lxc-start.sgml.in
    M doc/ja/lxc-stop.sgml.in
    M doc/ja/lxc-top.sgml.in
    M doc/ja/lxc-unfreeze.sgml.in
    M doc/ja/lxc-unshare.sgml.in
    M doc/ja/lxc-user-nic.sgml.in
    M doc/ja/lxc-usernet.sgml.in
    M doc/ja/lxc-usernsexec.sgml.in
    M doc/ja/lxc-wait.sgml.in
    M doc/ja/lxc.conf.sgml.in
    M doc/ja/lxc.container.conf.sgml.in
    M doc/ja/lxc.sgml.in
    M doc/ja/lxc.system.conf.sgml.in

  Log Message:
  -----------
  Convert punctuation marks in Japanese man pages

This only converts punctuation marks from FULLWIDTH COMMA/FULL STOP to
IDEOGRAPHIC COMMA/FULL STOP in Japanese man pages. The contents of man
pages do not change at all.

Signed-off-by: KATOH Yasufumi <karma at jazz.email.ne.jp>
Acked-by: Stéphane Graber <stgraber at ubuntu.com>


  Commit: bca6359e19d1047035a1fa1fc924bd220a4d0909
      https://github.com/lxc/lxc/commit/bca6359e19d1047035a1fa1fc924bd220a4d0909
  Author: Serge Hallyn <serge.hallyn at ubuntu.com>
  Date:   2014-04-30 (Wed, 30 Apr 2014)

  Changed paths:
    M src/lxc/lxc_user_nic.c

  Log Message:
  -----------
  lxc-user-nic: handle failure in create_nic

Failures were being ignored, leading up to an eventual segfault.

Signed-off-by: Serge Hallyn <serge.hallyn at ubuntu.com>
Acked-by: Stéphane Graber <stgraber at ubuntu.com>


  Commit: 2d309ce7718db907c6a28aed5899c131984a05c0
      https://github.com/lxc/lxc/commit/2d309ce7718db907c6a28aed5899c131984a05c0
  Author: Dwight Engen <dwight.engen at oracle.com>
  Date:   2014-04-30 (Wed, 30 Apr 2014)

  Changed paths:
    M src/lxc/confile.c

  Log Message:
  -----------
  allow all iX86 strings for lxc.arch

This change accepts all the same strings for lxc.arch that setarch(8) does.

Note that we continue to parse plain x86 as PER_LINUX32 so as not to break
existing lxc configuration files.

Signed-off-by: Dwight Engen <dwight.engen at oracle.com>
Signed-off-by: Serge Hallyn <serge.hallyn at ubuntu.com>


  Commit: 28b939d6c5eb14122fe20d6ecc826fe4d2393aa5
      https://github.com/lxc/lxc/commit/28b939d6c5eb14122fe20d6ecc826fe4d2393aa5
  Author: S.Çağlar Onur <caglar at 10ur.org>
  Date:   2014-04-30 (Wed, 30 Apr 2014)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  revert 1d16785 - fixes #191

According to Serge, we no longer need to keep cgmanager connection open.

As long as my tests go it seems to be working fine.

Signed-off-by: S.Çağlar Onur <caglar at 10ur.org>
Signed-off-by: Serge Hallyn <serge.hallyn at ubuntu.com>


  Commit: 1a255d795f1abf6ed1e81a5f50551d37286ddbf7
      https://github.com/lxc/lxc/commit/1a255d795f1abf6ed1e81a5f50551d37286ddbf7
  Author: Serge Hallyn <serge.hallyn at ubuntu.com>
  Date:   2014-04-30 (Wed, 30 Apr 2014)

  Changed paths:
    M config/apparmor/abstractions/container-base
    M config/apparmor/container-rules
    M config/apparmor/container-rules.base

  Log Message:
  -----------
  apparmor: allow writes to sem* and msg* sysctls

/proc/sys/kernel/sem* and /proc/sys/kernel/msg* are ipc sysctls
which are properly namespaced.  Allow writes to them from
containers.

Reported-by: Dan Kegel <dank at kegel.com>
Signed-off-by: Serge Hallyn <serge.hallyn at ubuntu.com>
Acked-by: Stéphane Graber <stgraber at ubuntu.com>


  Commit: e00666d54670e21397c1d140599ef6fbce4213b6
      https://github.com/lxc/lxc/commit/e00666d54670e21397c1d140599ef6fbce4213b6
  Author: Stéphane Graber <stgraber at ubuntu.com>
  Date:   2014-04-30 (Wed, 30 Apr 2014)

  Changed paths:
    M src/lxc/log.h
    M src/lxc/lxc_autostart.c
    M src/lxc/lxc_start.c
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  clang: Fix build warnings for 3.4

Signed-off-by: Stéphane Graber <stgraber at ubuntu.com>


  Commit: 52086eac30478437de9baa0a8783e81f5d84f59e
      https://github.com/lxc/lxc/commit/52086eac30478437de9baa0a8783e81f5d84f59e
  Author: S.Çağlar Onur <caglar at 10ur.org>
  Date:   2014-04-30 (Wed, 30 Apr 2014)

  Changed paths:
    M .gitignore

  Log Message:
  -----------
  fix minor typo in .gitignore

Signed-off-by: S.Çağlar Onur <caglar at 10ur.org>
Acked-by: Stéphane Graber <stgraber at ubuntu.com>


Compare: https://github.com/lxc/lxc/compare/ebd308923f28...52086eac3047

More information about the lxc-devel mailing list