[lxc-devel] [PATCH 1/3] Fix default package selection

[Stéphane Graber]

On Mon, Mar 31, 2014 at 10:20:48PM -0400, Leonid Isaev wrote:
> Do not cherry-pick packages for the default install to avoid dependency
> issues. Instead, install the base group modulo blacklisted packages.
> 
> Signed-off-by: Leonid Isaev <lisaev at umail.iu.edu>

Acked-by: Stéphane Graber <stgraber at ubuntu.com>

> ---
>  templates/lxc-archlinux.in | 32 ++++++--------------------------
>  1 file changed, 6 insertions(+), 26 deletions(-)
> 
> diff --git a/templates/lxc-archlinux.in b/templates/lxc-archlinux.in
> index 15283df..5aa9e53 100644
> --- a/templates/lxc-archlinux.in
> +++ b/templates/lxc-archlinux.in
> @@ -47,32 +47,12 @@ default_locale="en-US.UTF-8"
>  default_timezone="UTC"
>  pacman_config="/etc/pacman.conf"
>  
> -# sort of minimal package set
> -base_packages=(
> -    "systemd"
> -    "systemd-sysvcompat"
> -    "filesystem"
> -    "coreutils"
> -    "kmod"
> -    "procps"
> -    "psmisc"
> -    "pacman"
> -    "bash"
> -    "cronie"
> -    "iproute2"
> -    "iputils"
> -    "inetutils"
> -    "dhcpcd"
> -    "dnsutils"
> -    "nano"
> -    "grep"
> -    "less"
> -    "gawk"
> -    "sed"
> -    "tar"
> -    "gzip"
> -    "which"
> -)
> +# by default, install 'base' except the kernel
> +pkg_blacklist="linux"
> +base_packages=()
> +for pkg in $(pacman -Sqg base); do
> +   [ "${pkg_blacklist#*$pkg}" = "$pkg_blacklist" ] && base_packages+=($pkg)
> +done
>  declare -a additional_packages
>  
>  # split comma-separated string into an array
> -- 
> 1.8.5.3
> 
> -- 
> Leonid Isaev
> GnuPG key fingerprint: C0DF 20D0 C075 C3F1 E1BE  775A A7AE F6CB 164B 5A6D



-- 
Stéphane Graber
Ubuntu developer
http://www.ubuntu.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20140404/d48b98fa/attachment.pgp>