[lxc-devel] [PATCH 1/1] add c->may_control

Dwight Engen dwight.engen at oracle.com
Mon Sep 30 19:24:23 UTC 2013


On Mon, 30 Sep 2013 10:29:50 -0400
Stéphane Graber <stgraber at ubuntu.com> wrote:

> On Mon, Sep 30, 2013 at 09:53:56AM -0400, Dwight Engen wrote:
> > On Fri, 27 Sep 2013 21:01:07 -0500
> > Serge Hallyn <serge.hallyn at ubuntu.com> wrote:
> > 
> > > This is an api function which will return false if the container
> > > is running, and the caller may not talk to its monitor over its
> > > command socket.  Otherwise - if the container is not running, or
> > > the caller may access it - it returns true.
> > > 
> > > We can use this in several tools early on to prevent the segvs
> > > etc which we currently get.
> > > 
> > > Signed-off-by: Serge Hallyn <serge.hallyn at ubuntu.com>
> > 
> > Acked-by: Dwight Engen <dwight.engen at oracle.com>
> 
> Hi Serge,
> 
> So I'm not terribly familiar with the control code since the monitord
> changes, will that code work properly if the container socket is
> already in use (say by someone running lxc-wait on the container)?

Hi Stéphane,

A big part of that change was to support multiple, concurrent lxc-wait
and lxc-monitor clients which I did test at the time, so I'm glad to
hear from Serge that it is still working :)




More information about the lxc-devel mailing list