[lxc-devel] [PATCH 2/2] fix some larger memory leaks in cgroup code

Serge Hallyn serge.hallyn at ubuntu.com
Wed Sep 25 20:08:37 UTC 2013


Quoting Dwight Engen (dwight.engen at oracle.com):
> On Wed, 25 Sep 2013 14:44:07 -0400
> S.Çağlar Onur <caglar at 10ur.org> wrote:
> 
> > Uhh something is wrong with this commit
> 
> Hey Serge, I think this has to do with the rebase after the split up as
> it certinaly wasn't seg faulting on me originally. The split also

Yeah, sorry.  I'd lost the free(line) when moving code.  I'm not quite
sure how the lxc_cgroup_process_info_free(info) at the out3: label could
have actually worked for you, but maybe I dropped a zeroing out of
something somewhere.

> appears to have introduced a couple new leaks (ie. line in the
> subfunctions). Do you want me to just redo the cleanup fds & memory
> stuff on top of your change?

If you see any more bits I stupidly dropped in current git head,
please do.  I'm going to get going on the selinux patch now.

thanks,
-serge




More information about the lxc-devel mailing list