[lxc-devel] [PATCH] make process_lock return void

Dwight Engen dwight.engen at oracle.com
Mon Sep 16 20:19:53 UTC 2013


On Mon, 16 Sep 2013 15:59:45 -0400
Stéphane Graber <stgraber at ubuntu.com> wrote:

> On Mon, Sep 16, 2013 at 02:58:51PM -0500, Serge Hallyn wrote:
> > Quoting Serge Hallyn (serge.hallyn at ubuntu.com):
> > > pthread_mutex_lock() will only return an error if it was set to
> > > PTHREAD_MUTEX_ERRORCHECK and we are recursively calling it (and
> > > would otherwise have deadlocked).  If that's the case then log a
> > > message for future debugging and exit.  Trying to "recover" at
> > > that point is madness.
> > 
> > Heh, all right this patch doesn't compile.  But assuming noone
> > objects to the spirit of it I'll push one that does compile in
> > a bit.  (It's the base of the more general thread-safety patch
> > I'm working on)
> 
> I'm fine with the idea behind that patch.

+1.




More information about the lxc-devel mailing list