[lxc-devel] [PATCH] tests: Introduce lxc-test-concurrent for testing basic actions concurrently

[Serge Hallyn]

Quoting S.Çağlar Onur (caglar at 10ur.org):
> Hi Serge,
> 
> This seems to fix the creates but starts started to fail this time. One

Yeah I expected that.  Through send_state(), command.c and af_unix.c
need some process_lock()s too.  I had a preliminary patch on my other
laptop, but I wanted to see if I'd hit all the create ones and whether
that even helped at all before going on :)

> quick note, my concurrent.c still uses ubuntu as it's much more easy to
> replicate the issue with it.
> 
> diff --git a/src/tests/concurrent.c b/src/tests/concurrent.c
> index 7faf34c..ffc025c 100644
> --- a/src/tests/concurrent.c
> +++ b/src/tests/concurrent.c
> @@ -40,7 +40,7 @@ void * concurrent(void *arguments) {
>      args->return_code = 1;
>      if (strcmp(args->mode, "create") == 0) {
>          if (!c->is_defined(c)) {
> -            if (!c->create(c, "busybox", NULL, NULL, 1, NULL)) {
> +            if (!c->create(c, "ubuntu", NULL, NULL, 1, NULL)) {
>                  fprintf(stderr, "Creating the container (%s) failed...\n",
> name);
>                  goto out;
>              }

Ok, I'm going to assume noone objects to just triggering that on
argv[1] and push a patch to do that.  It'll do busybox by default,
or argv[1] if that is passed in.

thanks,
-serge