[lxc-devel] patch for the opensuse template

[Stéphane Graber]

On Wed, Sep 11, 2013 at 01:16:02PM +0200, Cedric Bosdonnat wrote:
> Hello Stéphane,
> 
> On Tue, 2013-09-10 at 12:29 -0400, Stéphane Graber wrote:
> > Yes, the mailing-list is the right way to send patches upstream.
> 
> Great.
> 
> > Note that we usually require you to add a Signed-off-by tag to your commits.
> > For this time around, I did it for you and pushed to the staging branch.
> 
> Thanks a lot for your help.
> 
> Is there a page documenting the coding habits in use in lxc? I haven't
> found anything like that on the sf.net page.

The CONTRIBUTING file in the git branch covers most of that I think.

> Cedric
> 
> > Acked-by: Stéphane Graber <stgraber at ubuntu.com>
> > 
> > 
> > > >From dfa2459afd1f8a05b50f354e2383b4bb8a71e578 Mon Sep 17 00:00:00 2001
> > > From: Cedric Bosdonnat <cbosdonnat at suse.com>
> > > Date: Tue, 10 Sep 2013 17:44:40 +0200
> > > Subject: [PATCH] Fixed opensuse template to make lxc-shutdown work.
> > > 
> > > The fix is described by
> > > https://wiki.archlinux.org/index.php/Linux_Containers#Container_cannot_be_shutdown_if_using_systemd
> > > ---
> > >  templates/lxc-opensuse.in | 3 +++
> > >  1 file changed, 3 insertions(+)
> > > 
> > > diff --git a/templates/lxc-opensuse.in b/templates/lxc-opensuse.in
> > > index 1fc7e21..c8004fd 100644
> > > --- a/templates/lxc-opensuse.in
> > > +++ b/templates/lxc-opensuse.in
> > > @@ -88,6 +88,9 @@ EOF
> > >      ln -s ../getty at .service $rootfs/etc/systemd/system/getty.target.wants/getty at tty3.service
> > >      ln -s ../getty at .service $rootfs/etc/systemd/system/getty.target.wants/getty at tty4.service
> > >  
> > > +    # copy host poweroff target as sigpwr target to make shutdown work
> > > +    # see https://wiki.archlinux.org/index.php/Linux_Containers#Container_cannot_be_shutdown_if_using_systemd
> > > +    cp /usr/lib/systemd/system/poweroff.target $rootfs/usr/lib/systemd/system/sigpwr.target
> > >  
> > >      touch $rootfs/etc/sysconfig/kernel
> > >  
> > > -- 
> > > 1.8.4
> > > 
> > 
> > > ------------------------------------------------------------------------------
> > > How ServiceNow helps IT people transform IT departments:
> > > 1. Consolidate legacy IT systems to a single system of record for IT
> > > 2. Standardize and globalize service processes across IT
> > > 3. Implement zero-touch automation to replace manual, redundant tasks
> > > http://pubads.g.doubleclick.net/gampad/clk?id=51271111&iu=/4140/ostg.clktrk
> > 
> > > _______________________________________________
> > > Lxc-devel mailing list
> > > Lxc-devel at lists.sourceforge.net
> > > https://lists.sourceforge.net/lists/listinfo/lxc-devel
> > 
> > 
> 
> 

-- 
Stéphane Graber
Ubuntu developer
http://www.ubuntu.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20130911/f3a74c4e/attachment.pgp>